[#4249] - Allow JURI to be injected nice, but...
- Closed
- 17 Apr 2015
- Medium
- Build: staging
- # 4249
- Diff
- bweston92:patch-1
- Failure The Travis CI build failed Details
User tests: Successful: Unsuccessful:
I'm not to sure about this as when DI is implemented all injected JUri instances would be a shared instance of the current request (Currently JFactory::getUri();). But for the time being doing new JUri isn't making it possible for my https site to load Google maps as the scheme on an empty JUri instance is null.
There is another way of doing this which would be modifying JUri setting the construct to accept 'SERVER' and then $this->populateFromServer();
jissues-bot
- | Labels |
Added:
?
|
||
@wilsonge JGoogleEmbedMaps when no JUri is given it creates a new instance which doesn't contain the current information like the scheme. So therefore when you're on HTTPS and JUri returns null for getScheme causes isSecure on the embed to return false and therefore the map won't load as it is insecure content on a secure site.
brianteeman
- | Category | ⇒ | Libraries |
Can you provide test instructions please?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4249.
Please update to the latest staging to solve the unittest errors and fix the merge conflict(s).
Again not got time to do that.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-04-17 13:21:48 |
| Closed_By | ⇒ | bweston92 | |
| Labels |
Removed:
?
|
||
Hi,
So what are you actually trying to do here? You want the default value to be the current URL of the page?