[#4248] - CodeMirror 4.6
- Closed
- 8 Oct 2014
- Medium
- Build: 3.4-dev
- Easy Test
- # 4248
- Diff
- okonomiyaki3000:CodeMirrorUpdate
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Steps to reproduce the issue
There's no issue. Just an update to CodeMirror.
Expected result
CodeMirror will be v4.5 as seen here http://codemirror.net/doc/releases.html
Actual result
System information (as much as possible)
jissues-bot
- | Labels |
Added:
?
|
||
What's going on with these build failures?
Not all related to this PR. There are some deprecated Messsages like PHPUnit_Framework_Assert::assertTag is deprecated
and on CS Issue that Travis find
FILE: .../joomla-cms/components/com_config/view/modules/tmpl/default_options.php
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
27 | ERROR | Increment and decrement operators must be bracketed when used in
| | string concatenation
--------------------------------------------------------------------------------
| Easy | No | ⇒ | Yes |
| Category | ⇒ | External Library Plugins |
@test successful install and testing your branche https://github.com/okonomiyaki3000/joomla-cms/archive/CodeMirrorUpdate.zip
This comment was created with the J!Tracker Application at http://issues.joomla.org/.
I agree those are weird. Looks like wrong encoding but, upon closer inspection, I think it's actually supposed to be that way. In any case, they're irrelevant. Those files are included in the CodeMirror package but they are just html files and not related to the use of CodeMirror in anyway. They are working demos of each mode. We will never use them but it's troublesome to remove them all from the package.
@test still successfull using https://github.com/okonomiyaki3000/joomla-cms/archive/CodeMirrorUpdate.zip
BTW: the ��� are fixed with the last commits :)
Thanks @okonomiyaki3000 
Works OK for me
roland-d
- | Status | Pending | ⇒ | Ready to Commit |
phproberto
- | Labels |
Added:
?
|
||
mbabker
- | Title |
|
||||||
| Status | Ready to Commit | ⇒ | Closed | ||||
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-10-08 14:19:35 | ||||
What's going on with these build failures?