[#4250] - Allow server-relative URLs in redirection
- Closed
- 10 Oct 2014
- Medium
- Build: 2.5.x
- Easy Test
- # 4250
- Diff
- jo-sf:patch-1
User tests: Successful: Unsuccessful:
Suppose you have a web server using Joomla where this web server is both reachable via http://www.example.org/ and http:/example.org/. With the current implementation of the redirection plugin you need to define two redirections within the redirect manager component for every page you want to automatically redirect from its old location to its new location:
old page: http://www.example.org/path/to/old/page.html
=> new page: http://www.example.org/path/to/new/page.html
old page: http://example.org/path/to/old/page.html
=> new page: http://example.org/path/to/new/page.html
With my proposed file change it would be sufficient to define only one redirection in this case:
old server-relative page: /path/to/old/page.html
=> new server-relative page: /path/to/new/page.html
jissues-bot
- | Labels |
Added:
?
|
||
Maybe these lines should be changed too in order to have a consistent code style here?
Oh sorry this are the 2.5.x PR. There we not use all types of CS. But if you send the seccond PR against the staging branche yes this lines should be changed too but the most is allready done there :)
https://github.com/joomla/joomla-cms/blob/staging/plugins/system/redirect/redirect.php
thanks @jo-sf it also work ok on j2.5 using the last Nightly Build
This comment was created with the J!Tracker Application at http://issues.joomla.org/.
| Category | ⇒ | Front End Plugins |
| Easy | No | ⇒ | Yes |
@test ok on version 2.5.24
This comment was created with the J!Tracker Application at http://issues.joomla.org/.
thanks @b2z moving to RTC now
This comment was created with the J!Tracker Application at http://issues.joomla.org/.
| Status | Pending | ⇒ | Ready to Commit |
phproberto
- | Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-10-10 12:21:14 |
zero-24, I made the changes in my patch as you suggested, but please keep in mind that I simply mimicked the code style you find some lines above my insertion: the { are often not in a line for themselves and the string concatenation in the lines 55-57 is also written without spaces. Maybe these lines should be changed too in order to have a consistent code style here?