[#42447] - [5.1] Use Dialog for Plugin editing
- Fixed in Code Base
- 10 Jan 2024
- Medium
- Build: 5.1-dev
- # 42447
- Diff
- Fedik:popup-plugin-edit
User tests: Successful: Unsuccessful:
Summary of Changes
Use Dialog for Plugin editing modals.
Similar to #42423
Testing Instructions
Run npm install.
Disable plugins:
Content - Smart Search
System - Redirect
Visit Finder Index overview, you should see a message about disable pplugin, with link to edit it. Try to use it for change plugin state.
Visit Redirects overview, you should see a message about disable pplugin, with link to edit it. Try to use it for change plugin state.
Actual result BEFORE applying this Pull Request
Works with BS modal
Expected result AFTER applying this Pull Request
Works with Joomla Dialog
Link to documentations
Please select:
- Documentation link for docs.joomla.org:
- No documentation changes for docs.joomla.org needed
- Pull Request link for manual.joomla.org: joomla/Manual#208
- No documentation changes for manual.joomla.org needed
References:
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_finder com_plugins com_redirect JavaScript Repository NPM Change Libraries |
| Labels |
Added:
Feature
NPM Resource Changed
PR-5.1-dev
|
||
I have tested this item ✅ successfully on 974f595
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42447.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42447.
| Labels |
Added:
RTC
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-01-10 14:11:42 |
| Closed_By | ⇒ | LadySolveig |
Thank you @Fedik and also for testing @Quy @viocassel
This is completely wrong - at least for the redirects. It stops checking if the plugin is enabled or disabled. it only checks if the plugin is installed
I have tested this item ✅ successfully on 974f595
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42447.