RTC PR-5.1-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
2 Dec 2023

Pull Request for Issue ##40678 .

Summary of Changes

When sending html mails created with com_mails it is possible to include images.

The function convertRelativeToAbsoluteUrls ensures that the images have absolute references so that they will be loaded in the email. However if the image has been added to the email using the media manager it will include loading="lazy" and data-path=

This pr strips any references to loading and data-path

https://www.caniemail.com/search/?s=loading

Testing Instructions

Set the mail templates to use html
Add an image to one of the mail templates - i suggest the Global Configuration: Test Mail
Trigger the mail and check it

Actual result BEFORE applying this Pull Request

The code for the image in the email will be
<img src="https://j5.test/images/9.webp" width="1141" height="720" loading="lazy" data-path="local-images:/9.webp">

Expected result AFTER applying this Pull Request

The code for the image in the email will be
<img src="https://j5.test/images/9.webp" width="1141" height="720">

The originakl issue report was classified as a bug therefore it should be 5.0 but it seems more like a feature so I made it against 5.1 but happy to change that.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

39c0137 2 Dec 2023 avatar brianteeman data
avatar brianteeman brianteeman - open - 2 Dec 2023
avatar brianteeman brianteeman - change - 2 Dec 2023
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 Dec 2023
Category Libraries
avatar brianteeman brianteeman - change - 2 Dec 2023
The description was changed
avatar brianteeman brianteeman - edited - 2 Dec 2023
9e627d1 2 Dec 2023 avatar brianteeman cs
avatar brianteeman brianteeman - change - 2 Dec 2023
Labels Added: PR-5.1-dev
avatar paternax paternax - test_item - 10 Jan 2024 - Tested successfully
avatar paternax
paternax - comment - 10 Jan 2024

I have tested this item ✅ successfully on 9e627d1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42448.

avatar fgsw fgsw - test_item - 12 Jan 2024 - Tested successfully
avatar fgsw
fgsw - comment - 12 Jan 2024

I have tested this item ✅ successfully on 9e627d1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42448.

avatar Quy Quy - change - 12 Jan 2024
Status Pending Ready to Commit
avatar Quy
Quy - comment - 12 Jan 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42448.

avatar Quy Quy - change - 12 Jan 2024
Labels Added: RTC
avatar LadySolveig LadySolveig - change - 31 Jan 2024
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-01-31 00:10:17
Closed_By LadySolveig
avatar LadySolveig LadySolveig - close - 31 Jan 2024
avatar LadySolveig LadySolveig - merge - 31 Jan 2024
avatar LadySolveig
LadySolveig - comment - 31 Jan 2024

Thank you @brianteeman and also for testing and review @paternax @fgsw @Quy

avatar brianteeman
brianteeman - comment - 31 Jan 2024

thx

Add a Comment

Login with GitHub to post a comment