User tests: Successful: Unsuccessful:
Pull Request for Issue ##40678 .
When sending html mails created with com_mails it is possible to include images.
The function convertRelativeToAbsoluteUrls ensures that the images have absolute references so that they will be loaded in the email. However if the image has been added to the email using the media manager it will include loading="lazy" and data-path=
This pr strips any references to loading and data-path
https://www.caniemail.com/search/?s=loading
Set the mail templates to use html
Add an image to one of the mail templates - i suggest the Global Configuration: Test Mail
Trigger the mail and check it
The code for the image in the email will be
<img src="https://j5.test/images/9.webp" width="1141" height="720" loading="lazy" data-path="local-images:/9.webp">
The code for the image in the email will be
<img src="https://j5.test/images/9.webp" width="1141" height="720">
The originakl issue report was classified as a bug therefore it should be 5.0 but it seems more like a feature so I made it against 5.1 but happy to change that.
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
Status | New | ⇒ | Pending |
Category | ⇒ | Libraries |
Labels |
Added:
PR-5.1-dev
|
I have tested this item ✅ successfully on 9e627d1
Status | Pending | ⇒ | Ready to Commit |
RTC
Labels |
Added:
RTC
|
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-01-31 00:10:17 |
Closed_By | ⇒ | LadySolveig |
Thank you @brianteeman and also for testing and review @paternax @fgsw @Quy
thx
I have tested this item ✅ successfully on 9e627d1
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42448.