Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#42341] - [4.x] Don't force the process to terminate

NPM Resource Changed PR-4.4-dev Pending

User tests: Successful: Unsuccessful:

avatar C-Lodder
C-Lodder
13 Nov 2023

Pull Request for Issues discussed in #42325

Summary of Changes

This stops the build scripts forcing the process to terminate, which is preventing the Media Manager build task from completing.
Instead, this PR sets the exit code to be used when Node.js gracefully exists....on its own.

Testing Instructions

  1. Run npm i
  2. Check to see if media-manager-es5.js and media-manager-es5.min.js exist in media/com_media/js
avatar C-Lodder C-Lodder - open - 13 Nov 2023
avatar C-Lodder C-Lodder - change - 13 Nov 2023
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 13 Nov 2023
Category ⇒ JavaScript Repository NPM Change
avatar Fedik Fedik - test_item - 13 Nov 2023 - Tested successfully
avatar Fedik
Fedik - comment - 13 Nov 2023

I have tested this item ✅ successfully on d5dadc2

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42341.

avatar laoneo laoneo - change - 14 Nov 2023
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2023-11-14 07:23:46
Closed_By ⇒ laoneo
Labels Added: NPM Resource Changed PR-4.4-dev
avatar laoneo laoneo - close - 14 Nov 2023
avatar laoneo laoneo - merge - 14 Nov 2023
avatar laoneo
laoneo - comment - 14 Nov 2023

Packager is running fine now again. Merging to see if nightlies are also back. Thanks for the good work!

Add a Comment

Login with GitHub to post a comment