User tests: Successful: Unsuccessful:
Pull Request for Issue # .
production.env
and a development.env
file for the build env variablesconsole.log(process.env.NODE_ENV)
after
npm run build:com_media
should see PRODUCTION
npm run build:com_media:dev
should see DEVELOPMENT
npm run update
should see PRODUCTION
media/com_media/js/media-manager.min.js
???
All good
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
Status | New | ⇒ | Pending |
Category | ⇒ | Unit Tests Repository Administration com_admin com_content com_finder com_joomlaupdate com_media Language & Strings JavaScript NPM Change |
Labels |
Added:
?
Language Change
NPM Resource Changed
PR-5.0-dev
|
Category | Unit Tests Repository Administration com_admin com_content com_finder com_joomlaupdate com_media Language & Strings JavaScript NPM Change | ⇒ | Repository NPM Change |
I have tested this item ✅ successfully on 85f5be7
I have tested this item ✅ successfully on 85f5be7
Status | Pending | ⇒ | Ready to Commit |
RTC
Labels |
Added:
?
PR-4.4-dev
Removed: ? Language Change PR-5.0-dev |
Why is this needed?
Because set NODE_ENV=PRODUCTION && node build/build.js --com-media
does not work for me.
But not realy critical, can stay as it is.
I mean, we can close it if it is working for others, without this changes.
Labels |
Added:
?
Removed: ? |
Labels |
Added:
?
Removed: ? |
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-11-16 06:48:50 |
Closed_By | ⇒ | laoneo | |
Labels |
Added:
?
Removed: ? |
Can it be without a 2 files for 1 line? ?