Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#42340] - [4.4] Use .env files for the node tools

? NPM Resource Changed PR-4.4-dev Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
13 Nov 2023

Pull Request for Issue # .

Summary of Changes

  • Adding a production.env and a development.env file for the build env variables
  • Adjust the script tags on the package.json

Testing Instructions

  • add a console.log(process.env.NODE_ENV) after

    joomla-cms/build/build-modules-js/javascript/build-com_media-js.es6.js

    Line 14 in 12ce681

    const isProduction = process.env.NODE_ENV !== 'DEVELOPMENT';
  • Run the commands npm run build:com_media should see PRODUCTION
  • Run the commands npm run build:com_media:dev should see DEVELOPMENT
  • Run the commands npm run update should see PRODUCTION
  • All commands produce the file media/com_media/js/media-manager.min.js

Actual result BEFORE applying this Pull Request

???

Expected result AFTER applying this Pull Request

All good

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar dgrammatiko dgrammatiko - open - 13 Nov 2023
avatar dgrammatiko dgrammatiko - change - 13 Nov 2023
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 13 Nov 2023
Category ⇒ Unit Tests Repository Administration com_admin com_content com_finder com_joomlaupdate com_media Language & Strings JavaScript NPM Change
avatar Fedik
Fedik - comment - 13 Nov 2023

Can it be without a 2 files for 1 line? ?

avatar Fedik Fedik - change - 14 Nov 2023
Labels Added: ? Language Change NPM Resource Changed PR-5.0-dev
avatar joomla-cms-bot joomla-cms-bot - change - 14 Nov 2023
Category Unit Tests Repository Administration com_admin com_content com_finder com_joomlaupdate com_media Language & Strings JavaScript NPM Change ⇒ Repository NPM Change
avatar Fedik Fedik - test_item - 14 Nov 2023 - Tested successfully
avatar Fedik
Fedik - comment - 14 Nov 2023

I have tested this item ✅ successfully on 85f5be7

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42340.

avatar viocassel viocassel - test_item - 14 Nov 2023 - Tested successfully
avatar viocassel
viocassel - comment - 14 Nov 2023

I have tested this item ✅ successfully on 85f5be7

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42340.

avatar Quy Quy - change - 14 Nov 2023
Status Pending ⇒ Ready to Commit
avatar Quy
Quy - comment - 14 Nov 2023

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42340.

avatar Quy Quy - change - 14 Nov 2023
Labels Added: ? PR-4.4-dev
Removed: ? Language Change PR-5.0-dev
avatar laoneo
laoneo - comment - 15 Nov 2023

Why is this needed?

avatar Fedik
Fedik - comment - 15 Nov 2023

Because set NODE_ENV=PRODUCTION && node build/build.js --com-media does not work for me.
But not realy critical, can stay as it is.
I mean, we can close it if it is working for others, without this changes.

avatar Quy Quy - change - 15 Nov 2023
Labels Added: ?
Removed: ?
avatar dgrammatiko
dgrammatiko - comment - 15 Nov 2023

@laoneo there’s more nuance here about node 20 and env files (you can google it). The point is that although this is looking stupid is the right thing moving forward (there’s way more things that could be in those .env files, but little steps)

avatar Quy Quy - change - 16 Nov 2023
Labels Added: ?
Removed: ?
avatar laoneo laoneo - close - 16 Nov 2023
avatar laoneo laoneo - merge - 16 Nov 2023
avatar laoneo laoneo - change - 16 Nov 2023
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2023-11-16 06:48:50
Closed_By ⇒ laoneo
Labels Added: ?
Removed: ?

Add a Comment

Login with GitHub to post a comment