Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#42332] - Fix list select (with choicesjs) losing values in subform

? NPM Resource Changed bug PR-4.4-dev Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
11 Nov 2023

Pull Request for Issue #41791 .

Summary of Changes

Fix list select (with choicesjs) losing values in subform

Testing Instructions

Run npm install
Please follow #41791
Or create a subfrom with fancy-select:

<field type="subform" name="subform" label="subform" multiple="true">
  <form>
    <field type="list" name="list" label="list" layout="joomla.form.field.list-fancy-select">
      <option value="1">1</option>
      <option value="2">2</option>
      <option value="3">3</option>
      <option value="4">4</option>
    </field>
  </form>
</field>

Select some values and change order of subform rows

Actual result BEFORE applying this Pull Request

Values are resets

Expected result AFTER applying this Pull Request

Values stays as selected

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org:
  • No documentation changes for manual.joomla.org needed
avatar Fedik Fedik - open - 11 Nov 2023
avatar Fedik Fedik - change - 11 Nov 2023
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Nov 2023
Category ⇒ JavaScript Repository NPM Change
avatar AndySDH AndySDH - test_item - 11 Nov 2023 - Tested successfully
avatar AndySDH
AndySDH - comment - 11 Nov 2023

I have tested this item ✅ successfully on e28bb6a

Thank you, the fix works :)

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42332.

avatar viocassel viocassel - test_item - 11 Nov 2023 - Tested successfully
avatar viocassel
viocassel - comment - 11 Nov 2023

I have tested this item ✅ successfully on e28bb6a

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42332.

avatar Quy Quy - change - 11 Nov 2023
Status Pending ⇒ Ready to Commit
Labels Added: NPM Resource Changed bug PR-4.4-dev
avatar Quy
Quy - comment - 11 Nov 2023

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42332.

avatar laoneo laoneo - change - 13 Nov 2023
Labels Added: ?
avatar laoneo laoneo - change - 13 Nov 2023
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2023-11-13 09:31:13
Closed_By ⇒ laoneo
Labels Added: ?
Removed: ?
avatar laoneo laoneo - close - 13 Nov 2023
avatar laoneo laoneo - merge - 13 Nov 2023
avatar laoneo
laoneo - comment - 13 Nov 2023

Thanks!

Add a Comment

Login with GitHub to post a comment