Feeling Lucky
NPM Resource Changed
PR-4.4-dev
[#42331] - [4.4] Node 20
- Fixed in Code Base
- 11 Nov 2023
- Medium
- Build: 5.0-dev
- # 42331
- Diff
- dgrammatiko:4.4-dev-tools
User tests: Successful: Unsuccessful:
Pull Request for Issue #42265 (back porting to 4.4) .
Summary of Changes
- Node 18 Active Support ended 2 weeks ago (18 Oct 2023), so switching to 20
- Added missing semver package in the devDependencies
- use the helper handleErr fn
- Added a runtime conditional and a message for incompatible node versions
Testing Instructions
Run npm ci, everything still works
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Unit Tests Repository Administration com_admin com_content com_finder com_joomlaupdate com_media Language & Strings JavaScript NPM Change com_tags Front End |
| Labels |
Added:
?
Language Change
NPM Resource Changed
PR-5.0-dev
|
||
| Category | Unit Tests Repository Administration com_admin com_content com_finder com_joomlaupdate com_media Language & Strings JavaScript NPM Change com_tags Front End | ⇒ | Unit Tests Repository JavaScript NPM Change Front End Templates (site) |
| Labels |
Added:
?
PR-4.4-dev
Removed: ? Language Change |
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-11-11 15:20:33 |
| Closed_By | ⇒ | laoneo | |
| Labels |
Removed:
?
PR-5.0-dev
|
||
laoneo
- comment
- 11 Nov 2023
Thanks all for the quick fix.
dgrammatiko
- comment
- 11 Nov 2023
@laoneo please also commit joomla-projects/docker-images#72 to fix the packager. Right now it's (probably) still broken:
This PR fixes this issue: #42325 (comment)
I could reproduce it locally on an Ubuntu VM and have verified that it's fixed on the branch of this PR.
For fixing the currently failing 4.4-dev nightly build it will need this PR here and in addition joomla-projects/docker-images#72 .