[#42329] - Add data attributes to Menu Item
- Closed
- 6 Dec 2023
- Medium
- Build: 5.0-dev
- # 42329
- Diff
- astridx:dataattributes
User tests: Successful: Unsuccessful:
Summary of Changes
Add attributes to Menu Item
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_menus Language & Strings Libraries Modules Front End Templates (site) |
| Labels |
Added:
Language Change
PR-5.0-dev
|
||
| Labels |
Added:
Feature
|
||
I would not go this way, why don't use use custom fields?
Thank you for your answer, but I don't understand what you mean by that.
Custom fields are connected to content, right? How can I link them to menu items?
My solution at the moment is to override the output of mod_menu.
Perhaps it would be useful if you described the use case for this
As @brianteeman wrote. Will be happy to test your PR if you describe the use-case and add a test instruction.
I moved it to the 5.1-dev branch, as it is a new feature.
| Labels |
Added:
?
|
||
| Category | Administration com_menus Language & Strings Libraries Modules Front End Templates (site) | ⇒ | Administration com_menus Language & Strings JavaScript Repository NPM Change Libraries Modules Front End Plugins Templates (site) |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-12-06 18:49:15 |
| Closed_By | ⇒ | chmst | |
| Labels |
Added:
Test instructions missing
NPM Resource Changed
PR-5.1-dev
Removed: ? PR-5.0-dev |
||
We close this PR for now. If more information and testing instruction are added, we can re-open.
I would not go this way, why don't use use custom fields?