Feature ? PR-5.1-dev Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
9 Nov 2023

Summary of Changes

Use Dialog for Batch windows
The same as #40359 but for rest of Batch buttons.

Testing Instructions

Run npm install
Test Batch dialog for:

  • banners
  • contacts
  • newsfeeds
  • fields
  • field groups
  • menus
  • modules
  • tags
  • users

Actual result BEFORE applying this Pull Request

Works

Expected result AFTER applying this Pull Request

Works

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org: joomla/Manual#184
  • No documentation changes for manual.joomla.org needed

References:

avatar Fedik Fedik - open - 9 Nov 2023
avatar Fedik Fedik - change - 9 Nov 2023
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 9 Nov 2023
Category Administration com_banners com_contact com_fields com_menus com_modules com_newsfeeds com_tags
avatar Fedik Fedik - change - 10 Nov 2023
Labels Added: Feature PR-5.1-dev
avatar Quy Quy - test_item - 10 Nov 2023 - Tested successfully
avatar Quy
Quy - comment - 10 Nov 2023

I have tested this item ✅ successfully on 6b7061f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42328.

avatar viocassel viocassel - test_item - 11 Nov 2023 - Tested successfully
avatar viocassel
viocassel - comment - 11 Nov 2023

I have tested this item ✅ successfully on 6b7061f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42328.

avatar alikon alikon - change - 11 Nov 2023
Status Pending Ready to Commit
avatar alikon
alikon - comment - 11 Nov 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42328.

avatar LadySolveig LadySolveig - change - 14 Nov 2023
Labels Added: ?
avatar LadySolveig LadySolveig - change - 15 Nov 2023
Labels Added: ?
Removed: ?
avatar LadySolveig LadySolveig - change - 16 Nov 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-11-16 08:01:59
Closed_By LadySolveig
Labels Added: ?
Removed: ?
avatar LadySolveig LadySolveig - close - 16 Nov 2023
avatar LadySolveig LadySolveig - merge - 16 Nov 2023
avatar LadySolveig
LadySolveig - comment - 16 Nov 2023

Thank you for your work @Fedik !
And of course many thanks to our testers and @viocassel @Quy and @dgrammatiko for the review.

Add a Comment

Login with GitHub to post a comment