Feeling Lucky
NPM Resource Changed
bug
PR-5.0-dev
?
[#42258] - [5.0] Fix j+a shortcut in TinyMCE JoomlaHighlighter plugin
- Fixed in Code Base
- 1 Nov 2023
- Medium
- Build: 5.0-dev
- # 42258
- Diff
- Fedik:fix-ja-shortcut-in-highlighter
User tests: Successful: Unsuccessful:
Pull Request for Issue #42235 .
Summary of Changes
Fix j+a shortcut in TinyMCE JoomlaHighlighter plugin
The bug happen because the Highlighter located in shadow DOM.
Testing Instructions
Run npm install
Please follow #42235
Or open article editing, open source editor in TinyMCE, and type ja
Actual result BEFORE applying this Pull Request
The page reloads, you get a message "Article saved"
Expected result AFTER applying this Pull Request
You can type ja
Link to documentations
Please select:
- Documentation link for docs.joomla.org:
- No documentation changes for docs.joomla.org needed
- Pull Request link for manual.joomla.org:
- No documentation changes for manual.joomla.org needed
Reference:
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
dgrammatiko
- comment
- 1 Nov 2023
@Fedik could you please add a similar comment on the highlighter plugin so these lines won't be forgotten when the plugin gets the new dialog?
dgrammatiko
- comment
- 1 Nov 2023
I have tested this item ✅ successfully on daf3713
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42258.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-11-01 09:35:06 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
NPM Resource Changed
bug
PR-5.0-dev
?
|
||
HLeithner
- comment
- 1 Nov 2023
thanks
alejman2009
- comment
- 7 Nov 2023
This is nice thanks for taking a look on it.
I have tested this item ✅ successfully on daf3713
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42258.