[#42257] - Feature/4.4 dev api tag relationship content serializer
- Closed
- 1 Nov 2023
- Medium
- Build: 4.4-dev
- # 42257
- Diff
- alexandreelise:feature/4.4-dev-api-tag-relationship-content-serializer
User tests: Successful: Unsuccessful:
Based on the feedback of maintainers
Pull Request for Issue # .
No issues for this pull request
Summary of Changes
Add the Tag Relationship for ContentSerializer
Testing Instructions
Apply the patch
Run this command curl -X GET -H "X-Joomla-Token: YOUR_JOOMLA_API_TOKEN" -H "Accept: application/vnd.api+json" --url "https://example.org/api/index.php/v1/content/articles"
It should return a response in JSON:API format containing the tags relationship
Actual result BEFORE applying this Pull Request
The tag relationship does not appear when doing a GET request on /api/index.php/v1/content/articles
Expected result AFTER applying this Pull Request
The tag relationship appears successfully alongside the other relationships like category and created_by
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Unit Tests Repository Administration com_admin SQL |
| Labels |
Added:
?
PR-4.4-dev
|
||
| Category | Unit Tests Repository Administration com_admin SQL | ⇒ |
I have tested this item ✅ successfully on 2439f70
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42257.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-11-01 09:30:01 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
Maintainers Checked
Removed: ? |
||
@alexandreelise I must excuse my self because I misinterpreted your first pr #42244 as a bug fix which actually is not a bug fix as correctly marked by richard. I will close this pull request and reopen your #42244 pull request then I rebase it to 5.1 because we have a no feature policy for current branches (4.4 and 5.0). Since we have 2 tests ( Nicola, my self and the approval by george) I will directly merge it into 5.1.
I'm sorry for this chaotic workflow.
Don't worry @HLeithner we are not machines. Take care and have a great day.
@HLeithner PR done same as in 5.0-dev as suggested. #42257