Feature RTC Unit/System Tests PR-5.1-dev Pending

User tests: Successful: Unsuccessful:

avatar heelc29
heelc29
24 Oct 2023

Summary of Changes

Converts the feed site module to service provider

Testing Instructions

  • create site module feed
  • check site output

Note: system test added

Actual result BEFORE applying this Pull Request

module works
image

Expected result AFTER applying this Pull Request

module works
image

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed
avatar heelc29 heelc29 - open - 24 Oct 2023
avatar heelc29 heelc29 - change - 24 Oct 2023
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Oct 2023
Category Modules Front End JavaScript Unit Tests
avatar ceford ceford - test_item - 27 Oct 2023 - Tested successfully
avatar ceford
ceford - comment - 27 Oct 2023

I have tested this item ✅ successfully on c7773b9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42215.

avatar LadySolveig LadySolveig - change - 7 Nov 2023
Labels Added: Feature ? PR-5.1-dev
avatar heelc29 heelc29 - change - 18 Dec 2023
Labels Added: Unit/System Tests
Removed: ?
avatar viocassel viocassel - test_item - 16 Jan 2024 - Tested successfully
avatar viocassel
viocassel - comment - 16 Jan 2024

I have tested this item ✅ successfully on 9e552c8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42215.

avatar crimle crimle - test_item - 24 Feb 2024 - Tested successfully
avatar crimle
crimle - comment - 24 Feb 2024

I have tested this item ✅ successfully on 9e552c8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42215.

avatar richard67 richard67 - change - 24 Feb 2024
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 24 Feb 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42215.

avatar LadySolveig LadySolveig - change - 26 Feb 2024
Labels Added: RTC
avatar bembelimen bembelimen - change - 27 Feb 2024
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-02-27 23:55:10
Closed_By bembelimen
avatar bembelimen bembelimen - close - 27 Feb 2024
avatar bembelimen bembelimen - merge - 27 Feb 2024
avatar bembelimen
bembelimen - comment - 27 Feb 2024

Thank you!

avatar sandewt
sandewt - comment - 28 Feb 2024

Still one more comment, see file:
modules/mod_feed/src/Helper/FeedHelper.php

line 65:
deprecated DEPLOY_VERSION will be removed in 7.0

I expected, just like with other recent PRs, eg #42792
deprecated DEPLOY_VERSION will be removed in 6.0

Is there a reason for that?

Add a Comment

Login with GitHub to post a comment