Feeling Lucky
Feature
PR-5.1-dev
[#42214] - [5.1] Convert mod_banners to service provider
- Fixed in Code Base
- 24 Jan 2024
- Medium
- Build: 5.1-dev
- # 42214
- Diff
- heelc29:5.1/modules/site/banners
User tests: Successful: Unsuccessful:
Summary of Changes
Converts the banners site module to service provider
Testing Instructions
- create site module
Banners - check site output
Note: system test exists
https://github.com/joomla/joomla-cms/blob/5.1-dev/tests/System/integration/site/modules/mod_banners/Default.cy.js
Actual result BEFORE applying this Pull Request
module works
Expected result AFTER applying this Pull Request
module works
Link to documentations
Please select:
- No documentation changes for docs.joomla.org needed
- No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Front End |
| Labels |
Added:
Feature
PR-5.1-dev
|
||
viocassel
- comment
- 16 Jan 2024
I have tested this item ✅ successfully on 0c3ff13
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42214.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-01-24 18:30:28 |
| Closed_By | ⇒ | LadySolveig |
LadySolveig
- comment
- 24 Jan 2024
Thank you @heelc29 and for testing and review @ceford @viocassel @sandewt
I have tested this item ✅ successfully on 57e0557
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42214.