Pending

User tests: Successful: Unsuccessful:

avatar shane-clickingmad
shane-clickingmad
18 Oct 2023

Pull Request for Issue #40750 .

Summary of Changes

Only populate the menu items into $this->lookup if they are a direct match, or return_any_or_all is set to any.

Testing Instructions

Setup two tags.
Setup a menu item point to a singular tag
Setup a second menu item pointing to both tags, match type All
Populate articles into the first tag to show pagination within page (can change global config list limit to 5 to make this easier)
Navigate to the first menu item on the front end.
Observe pagination links

Actual result BEFORE applying this Pull Request

Pagination URL incorrectly pointing to second menu item (with multiple tags selected), instead of the current menu item.
Page: /tag-1 pagination link: /tag-1-and-2?start=5

Example: Page: /tag-1 pagination link: /tag-1?start=5

Expected result AFTER applying this Pull Request

Pagination URL's now correctly paginate through the current menu item.

Example: Page: /tag-1 pagination link: /tag-1-and-2?start=5

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar shane-clickingmad shane-clickingmad - open - 18 Oct 2023
avatar shane-clickingmad shane-clickingmad - change - 18 Oct 2023
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 Oct 2023
Category com_tags Front End
avatar exlemor
exlemor - comment - 21 Apr 2024

Hi @shane-clickingmad, I tried to follow your testing instructions step by step but I think something is missing as it did not yield what was supposed to be happen ;-(

Can you please check them so that I can test it again very soon.

(sorry)

avatar HLeithner HLeithner - change - 24 Apr 2024
Title
Update tag router to restrict lossy matches to menu items set to any
[4.4] Update tag router to restrict lossy matches to menu items set to any
avatar HLeithner HLeithner - edited - 24 Apr 2024
avatar fgsw fgsw - test_item - 29 Aug 2024 - Tested successfully
avatar fgsw
fgsw - comment - 29 Aug 2024

I have tested this item ✅ successfully on e0023c9

Without patch With patch
without with
Pagination URL show "menutwotags" Pagination URL show "menuonetag"

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42162.
avatar HLeithner
HLeithner - comment - 15 Nov 2024

This pull request has been automatically rebased to 5.2-dev.

avatar HLeithner HLeithner - change - 15 Nov 2024
Title
[4.4] Update tag router to restrict lossy matches to menu items set to any
[5.2] Update tag router to restrict lossy matches to menu items set to any
avatar HLeithner HLeithner - edited - 15 Nov 2024

Add a Comment

Login with GitHub to post a comment