User tests: Successful: Unsuccessful:
Pull Request for Issue #40750 .
Only populate the menu items into $this->lookup if they are a direct match, or return_any_or_all is set to any.
Setup two tags.
Setup a menu item point to a singular tag
Setup a second menu item pointing to both tags, match type All
Populate articles into the first tag to show pagination within page (can change global config list limit to 5 to make this easier)
Navigate to the first menu item on the front end.
Observe pagination links
Pagination URL incorrectly pointing to second menu item (with multiple tags selected), instead of the current menu item.
Page: /tag-1 pagination link: /tag-1-and-2?start=5
Example: Page: /tag-1 pagination link: /tag-1?start=5
Pagination URL's now correctly paginate through the current menu item.
Example: Page: /tag-1 pagination link: /tag-1-and-2?start=5
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
Status | New | ⇒ | Pending |
Category | ⇒ | com_tags Front End |
Title |
|
I have tested this item ✅ successfully on e0023c9
Without patch | With patch |
---|---|
Pagination URL show "menutwotags" | Pagination URL show "menuonetag" |
This pull request has been automatically rebased to 5.2-dev.
Title |
|
Hi @shane-clickingmad, I tried to follow your testing instructions step by step but I think something is missing as it did not yield what was supposed to be happen ;-(
Can you please check them so that I can test it again very soon.
(sorry)