Feeling Lucky
Feature
RTC
NPM Resource Changed
PR-5.1-dev
[#42081] - [5.1] Use Dialog for Shortcut overview
- Fixed in Code Base
- 16 Dec 2023
- Medium
- Build: 5.1-dev
- # 42081
- Diff
- Fedik:dialog-for-shortcut-plg
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Summary of Changes
Use Dialog for Shortcut overview, instead of BS modal.
Testing Instructions
Run npm install
Check shortcut overview works as before (j + x shortcut).
Actual result BEFORE applying this Pull Request
Works
Expected result AFTER applying this Pull Request
Works
Link to documentations
Please select:
- Documentation link for docs.joomla.org:
- No documentation changes for docs.joomla.org needed
- Pull Request link for manual.joomla.org:
- No documentation changes for manual.joomla.org needed
Reference:
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change Front End Plugins |
| Labels |
Added:
Feature
NPM Resource Changed
PR-5.1-dev
|
||
viocassel
- comment
- 14 Nov 2023
I have tested this item ✅ successfully on 7ff0791
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42081.
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 14 Nov 2023
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42081.
| Labels |
Added:
RTC
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-12-16 15:33:45 |
| Closed_By | ⇒ | LadySolveig |
LadySolveig
- comment
- 16 Dec 2023
Thank you for your work @Fedik !
I am also very happy about the eager testers and the review - thank you @JonasAtZwetschke @viocassel and @dgrammatiko
I have tested this item ✅ successfully on 7ff0791
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42081.