[#42080] - [5.0] Dark mode for quickicons
- Closed
- 8 Oct 2023
- Medium
- Build: 5.0-dev
- # 42080
- Diff
- brianteeman:quickicons
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Summary of Changes
This feels a bit hacky someone better than me can improve it I am sure.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository NPM Change |
@coolcat-creations @MacJoom what's your plan for this, seems similar like the alerts for me?
Yes that's also already in the draft
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-10-08 05:00:49 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
NPM Resource Changed
PR-5.0-dev
Dark Mode
|
||
Sorry I don't understand why this is closed. It is no different to any of the other dark mode fixes that you have merged in the last week. First impressions count and this fixes a bug on the very first page of the admin. In addition it actually works whereas the equivalent in the large pr that will not be merged in 5.0 does not
waiting for a review by @wilsonge and a successful test