NPM Resource Changed bug PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
7 Oct 2023

Pull Request for Issue #42065 .

Summary of Changes

Fix dialog heigh for Safari

Testing Instructions

Run npm install
Please follow #42065

Actual result BEFORE applying this Pull Request

Dialog with 2px heaigh

Expected result AFTER applying this Pull Request

Dialog with normal height

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org:
  • No documentation changes for manual.joomla.org needed
avatar Fedik Fedik - open - 7 Oct 2023
avatar Fedik Fedik - change - 7 Oct 2023
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 7 Oct 2023
Category Repository NPM Change
avatar Fedik Fedik - change - 7 Oct 2023
Labels Added: NPM Resource Changed PR-5.0-dev
avatar brianteeman brianteeman - test_item - 7 Oct 2023 - Tested successfully
avatar brianteeman
brianteeman - comment - 7 Oct 2023

I have tested this item ✅ successfully on a45f143


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42079.

avatar brianteeman
brianteeman - comment - 7 Oct 2023

Replicated the bug in safari
Confirmed that it is now fixed in safari and verified it still works in other browsers

image

avatar HLeithner HLeithner - close - 7 Oct 2023
avatar HLeithner HLeithner - merge - 7 Oct 2023
avatar HLeithner HLeithner - change - 7 Oct 2023
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-10-07 17:25:56
Closed_By HLeithner
Labels Added: bug
avatar HLeithner
HLeithner - comment - 7 Oct 2023

thanks

Add a Comment

Login with GitHub to post a comment