Feeling Lucky
PR-5.0-dev
[#41987] - [5.0] ActionsDropdown::$dropDownList issue
- Fixed in Code Base
- 30 Sep 2023
- Medium
- Build: 5.0-dev
- # 41987
- Diff
- Denitz:5.0_Invalid_PHPDoc_in_ActionsDropdown__$dropDownList
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Summary of Changes
ActionsDropdown::$dropDownList is declared as string while it's string[]
Once rendered, the array is casted to null (I guess to free memory), but it's an array actually and all any next further call to add a button will produce warning on adding element to null.
Testing Instructions
Apply patch.
Actual result BEFORE applying this Pull Request
See IDE warning for static::$dropDownList[] = ... code.
Expected result AFTER applying this Pull Request
No IDE warnings.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Status | New | ⇒ | Pending |
HLeithner
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-09-30 20:07:32 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
PR-5.0-dev
|
||