bug PR-5.0-dev PR-5.1-dev PR-5.2-dev Pending

User tests: Successful: Unsuccessful:

avatar Denitz
Denitz
28 Sep 2023

Summary of Changes

Prefer Classname::class over class string usage to simplify the class usage find in IDE.
Prefer static::class over get_called_class() for simplicity.

Testing Instructions

Apply patch.

Actual result BEFORE applying this Pull Request

See complex code, a class can't be missed in usage find via IDE.

Expected result AFTER applying this Pull Request

Simple code, class usage is complete in IDE.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

ead5862 28 Sep 2023 avatar Denitz fix
avatar joomla-cms-bot joomla-cms-bot - change - 28 Sep 2023
Category Administration com_installer Libraries Modules Front End Plugins
avatar Denitz Denitz - open - 28 Sep 2023
avatar Denitz Denitz - change - 28 Sep 2023
Status New Pending
avatar Denitz Denitz - change - 30 Sep 2023
Labels Added: PR-5.0-dev
avatar HLeithner HLeithner - change - 30 Sep 2023
Title
[5.0] simplify class usage
[5.1] simplify class usage
avatar HLeithner HLeithner - edited - 30 Sep 2023
avatar HLeithner
HLeithner - comment - 30 Sep 2023

This pull request has been automatically rebased to 5.1-dev.

avatar Denitz Denitz - change - 3 Oct 2023
Labels Added: Feature
avatar HLeithner
HLeithner - comment - 2 Sep 2024

This pull request has been automatically rebased to 5.2-dev.

avatar HLeithner HLeithner - change - 2 Sep 2024
Title
[5.1] simplify class usage
[5.2] simplify class usage
avatar HLeithner HLeithner - edited - 2 Sep 2024
avatar Hackwar
Hackwar - comment - 11 Sep 2024

Hello @Denitz, thank you for this PR. Could you solve the conflicts and then we'll try to get this in as soon as possible. Thank you!

avatar Denitz Denitz - change - 11 Sep 2024
Labels Added: bug PR-5.1-dev PR-5.2-dev
Removed: Feature
avatar joomla-cms-bot joomla-cms-bot - change - 11 Sep 2024
Category Administration com_installer Libraries Modules Front End Plugins Administration com_installer Libraries Front End Plugins
avatar Denitz
Denitz - comment - 12 Sep 2024

@Hackwar Solved!

avatar Hackwar
Hackwar - comment - 22 Nov 2024

I'm sorry that this didn't go into 5.2.0. Since this is not really a bugfix, but a code-refactoring, I'm going to push this over to 5.3, but I'm going to ask for people to finally test this, so that we can merge it then.

avatar Hackwar Hackwar - change - 22 Nov 2024
Title
[5.2] simplify class usage
[5.3] simplify class usage
avatar Hackwar Hackwar - edited - 22 Nov 2024

Add a Comment

Login with GitHub to post a comment