[#41986] - [6.1] simplify class usage
- Ready to Commit
- Medium
- Build: 6.1-dev
- # 41986
- Diff
- Denitz:5.0_Simplify_class_usage
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Summary of Changes
Prefer Classname::class over class string usage to simplify the class usage find in IDE.
Prefer static::class over get_called_class() for simplicity.
Testing Instructions
Apply patch.
Actual result BEFORE applying this Pull Request
See complex code, a class can't be missed in usage find via IDE.
Expected result AFTER applying this Pull Request
Simple code, class usage is complete in IDE.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Administration com_installer Libraries Modules Front End Plugins |
| Status | New | ⇒ | Pending |
| Labels |
Added:
PR-5.0-dev
|
||
| Title |
|
||||||
| Labels |
Added:
Feature
|
||
This pull request has been automatically rebased to 5.2-dev.
| Title |
|
||||||
| Labels |
Added:
bug
PR-5.1-dev
PR-5.2-dev
Removed: Feature |
||
| Category | Administration com_installer Libraries Modules Front End Plugins | ⇒ | Administration com_installer Libraries Front End Plugins |
I'm sorry that this didn't go into 5.2.0. Since this is not really a bugfix, but a code-refactoring, I'm going to push this over to 5.3, but I'm going to ask for people to finally test this, so that we can merge it then.
| Title |
|
||||||
Not really. We will get to this one eventually.
This pull request has been automatically rebased to 5.4-dev.
two years have passed...
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-10-30 11:40:34 |
| Closed_By | ⇒ | Denitz | |
| Labels |
Added:
PR-5.3-dev
Removed: PR-5.0-dev PR-5.1-dev PR-5.2-dev |
||
Please reopen, it will get merged eventually :)
But rebase to 6.1
| Status | Closed | ⇒ | New |
| Closed_Date | 2025-10-30 11:40:34 | ⇒ | |
| Closed_By | Denitz | ⇒ | |
| Labels |
Added:
PR-5.4-dev
|
||
| Status | New | ⇒ | Pending |
| Title |
|
||||||
I have tested this item ✅ successfully on 91932ac
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41986.
| Labels |
Added:
PR-6.1-dev
Removed: PR-5.3-dev PR-5.4-dev |
||
I have tested this item ✅ successfully on 6df1d87
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41986.
I have tested this item ✅ successfully on 6df1d87
LGTM - Thanks!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41986.
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41986.
| Status | Pending | ⇒ | Ready to Commit |
| Build | 5.0-dev | ⇒ | 6.1-dev |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41986.
This pull request has been automatically rebased to 5.1-dev.