[#41977] - [5.2] Invalid behavior of WorkflowModel::publish()
- Pending
- Medium
- Build: 5.0-dev
- # 41977
- Diff
- Denitz:5.0_Invalid_WorkflowModel__publish()
User tests: Successful: Unsuccessful:
Summary of Changes
Admin WorkflowModel::publish() sets the modification date on publish/unpublish without checking of actual publish/unpublish result.
On publish/unpublish of multiple items only the last item's modification date is changed,
No modified_by is updated.
Applies to Joomla 4 as well.
Testing Instructions
Create multiple workflows, publish/unpublish multiple items at once from Actions button group.
Actual result BEFORE applying this Pull Request
See #__workflows table, modified_by is not updated, modified is only updated for the last item in the list.
Expected result AFTER applying this Pull Request
modified_by and modified are updated as required.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Administration com_workflow |
| Status | New | ⇒ | Pending |
| Labels |
Added:
Updates Requested
bug
PR-5.0-dev
|
||
| Title |
|
||||||
This pull request has been automatically rebased to 5.2-dev.
| Title |
|
||||||
@Denitz Could you please make the changes that HLeithner mentioned in his comment: #41977 (comment)
| Labels |
Added:
PR-5.1-dev
PR-5.2-dev
Removed: PR-5.0-dev |
||
| Labels |
Removed:
PR-5.1-dev
|
||
Additional we would like to have a PR to set the modified/by in the
Table::publish()method
Should this be done on Joomla\CMS\Table\Table or we should implement an override for publish method in WorkflowTable class? From what I see, if we handle it directly on Joomla\CMS\Table\Table, it could break extensions which uses modified, modified_by field for different purpose (we do not know how developers could use these fields in their extensions - if exist)
We discussed this in the maintainer meeting and decided to completely remove the modified stuff in the publish function in workflow to be consistent with the rest of the cms.
Additional we would like to have a PR to set the modified/by in the
Table::publish()method