Updates Requested bug PR-5.1-dev PR-5.2-dev Pending

User tests: Successful: Unsuccessful:

avatar Denitz
Denitz
28 Sep 2023

Summary of Changes

Admin WorkflowModel::publish() sets the modification date on publish/unpublish without checking of actual publish/unpublish result.

On publish/unpublish of multiple items only the last item's modification date is changed,

No modified_by is updated.

Applies to Joomla 4 as well.

Testing Instructions

Create multiple workflows, publish/unpublish multiple items at once from Actions button group.

Actual result BEFORE applying this Pull Request

See #__workflows table, modified_by is not updated, modified is only updated for the last item in the list.

Expected result AFTER applying this Pull Request

modified_by and modified are updated as required.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

ee92c52 28 Sep 2023 avatar Denitz fix
avatar joomla-cms-bot joomla-cms-bot - change - 28 Sep 2023
Category Administration com_workflow
avatar Denitz Denitz - open - 28 Sep 2023
avatar Denitz Denitz - change - 28 Sep 2023
Status New Pending
avatar HLeithner
HLeithner - comment - 18 Oct 2023

We discussed this in the maintainer meeting and decided to completely remove the modified stuff in the publish function in workflow to be consistent with the rest of the cms.

Additional we would like to have a PR to set the modified/by in the Table::publish() method

avatar bembelimen bembelimen - change - 14 Mar 2024
Labels Added: Updates Requested bug PR-5.0-dev
avatar HLeithner HLeithner - change - 24 Apr 2024
Title
[5.0] Invalid behavior of WorkflowModel::publish()
[5.1] Invalid behavior of WorkflowModel::publish()
avatar HLeithner HLeithner - edited - 24 Apr 2024
avatar HLeithner
HLeithner - comment - 2 Sep 2024

This pull request has been automatically rebased to 5.2-dev.

avatar HLeithner HLeithner - change - 2 Sep 2024
Title
[5.1] Invalid behavior of WorkflowModel::publish()
[5.2] Invalid behavior of WorkflowModel::publish()
avatar HLeithner HLeithner - edited - 2 Sep 2024
avatar pe7er
pe7er - comment - 11 Sep 2024

@Denitz Could you please make the changes that HLeithner mentioned in his comment: #41977 (comment)

avatar Denitz Denitz - change - 15 Sep 2024
Labels Added: PR-5.1-dev PR-5.2-dev
Removed: PR-5.0-dev
avatar Denitz
Denitz - comment - 15 Sep 2024

@pe7er I removed modified logic from WorkflowModel::publish()
Unfortunately, have no time for a PR to set the modified/by in the Table::publish() method.

Add a Comment

Login with GitHub to post a comment