[#41988] - [5.2] Remove call_user_func()
- Fixed in Code Base
- 25 Aug 2024
- Medium
- Build: 5.0-dev
- # 41988
- Diff
- Denitz:5.0_Remove_call_user_func
User tests: Successful: Unsuccessful:
Summary of Changes
Remove call_user_func() in favour of direct call which is faster.
Testing Instructions
Apply patch.
Actual result BEFORE applying this Pull Request
Slow call_user_func() call on form field filter.
Expected result AFTER applying this Pull Request
Fast call.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Status | New | ⇒ | Pending |
| Title |
|
||||||
| Labels |
Added:
Feature
PR-5.0-dev
|
||
This pull request has been automatically rebased to 5.2-dev.
| Title |
|
||||||
I have tested this item ✅ successfully on 38bed88
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41988.
I have tested this item ✅ successfully on 38bed88
I tested the PR successfully.
I tested the speed using microtime and hrtime
microtime
Before 0.54661
After 0.060788
hrtime
Before 0.002111 miliseconds
After 0.001321 miliseconds
$start = hrtime(true);
// the statement
$end = hrtime(true);
$eta = ($end-$start) / 1e+6;This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41988.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41988.
| Labels |
Added:
RTC
PR-5.2-dev
Removed: PR-5.0-dev |
||
Thank you for this contribution! ?
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-08-25 19:58:57 |
| Closed_By | ⇒ | Hackwar |
This pull request has been automatically rebased to 5.1-dev.