User tests: Successful: Unsuccessful:
Category | ⇒ | Administration com_modules |
Status | New | ⇒ | Pending |
ah ok then - will go down the js route to fix it
Category | Administration com_modules | ⇒ | JavaScript Repository NPM Change |
Labels |
Added:
PR-5.0-dev
|
I have tested this item ✅ successfully on 8c41ea1
I have tested this item ✅ successfully on 8c41ea1
Status | Pending | ⇒ | Ready to Commit |
RTC
Labels |
Added:
?
Release Blocker
NPM Resource Changed
bug
|
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-09-27 13:27:19 |
Closed_By | ⇒ | wilsonge |
Thanks!
thanks
About to head to bed but I think switching https://github.com/joomla/joomla-cms/blob/4.3-dev/build/media_source/com_modules/js/admin-module-search.es6.js#L67 this line from
.card-body
to.new-module-caption
makes things work. Only a did a very quick test locally though.The problem is the card-body class overrides the text color in dark mode to stuff that doesn't pass a11y. But it doesn't apply any of the usual padding because it's not inside a
.card
bootstrap element.