Feeling Lucky
?
Release Blocker
NPM Resource Changed
bug
PR-5.0-dev
[#41943] - [5.0] Select New Module
- Fixed in Code Base
- 27 Sep 2023
- Medium
- Build: 5.0-dev
- # 41943
- Diff
- brianteeman:41920fix
User tests: Successful: Unsuccessful:
joomla-cms-bot
- | Category | ⇒ | Administration com_modules |
| Status | New | ⇒ | Pending |
brianteeman
- comment
- 26 Sep 2023
ah ok then - will go down the js route to fix it
| Category | Administration com_modules | ⇒ | JavaScript Repository NPM Change |
| Labels |
Added:
PR-5.0-dev
|
||
richard67
- comment
- 27 Sep 2023
I have tested this item ✅ successfully on 8c41ea1
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41943.
Quy
- comment
- 27 Sep 2023
I have tested this item ✅ successfully on 8c41ea1
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41943.
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 27 Sep 2023
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41943.
| Labels |
Added:
?
Release Blocker
NPM Resource Changed
bug
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-09-27 13:27:19 |
| Closed_By | ⇒ | wilsonge |
wilsonge
- comment
- 27 Sep 2023
Thanks!
brianteeman
- comment
- 27 Sep 2023
thanks
About to head to bed but I think switching https://github.com/joomla/joomla-cms/blob/4.3-dev/build/media_source/com_modules/js/admin-module-search.es6.js#L67 this line from
.card-bodyto.new-module-captionmakes things work. Only a did a very quick test locally though.The problem is the card-body class overrides the text color in dark mode to stuff that doesn't pass a11y. But it doesn't apply any of the usual padding because it's not inside a
.cardbootstrap element.