[#41942] - [5.0] Fix installer never backing up old tables
- Fixed in Code Base
- 27 Sep 2023
- Medium
- Build: 5.0-dev
- # 41942
- Diff
- wilsonge:fix/installation-code-fix
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Fixes bug caused by #38914 which breaks table backups.
Summary of Changes
Table backups in installation are fixed with this patch
Note there might be a similar bug https://github.com/joomla/joomla-cms/blob/4.3-dev/installation/src/Helper/DatabaseHelper.php#L321 here where we reset the session objects. But I can't see us reusing the options so it's probably fine? Definitely needs another review
Testing Instructions
Steps to replicate the bug (thanks @brianteeman !!)
- install joomla with a db prefix of jos_
- on the final screen of the installer (where you get the link to site and admin) clear the cookies and delete configuration.php
- refresh the browser and you are back to the beginning of the installation
- enter EXACTLY the same values - especially the db prefix of jos_
Someone should probably validate that this doesn't break the cli installer too.
Actual result BEFORE applying this Pull Request
Error appears. null if you haven't got #41941 applied or a big list of errors if you do
Expected result AFTER applying this Pull Request
No errors and tables backed up
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Installation |
| Status | New | ⇒ | Pending |
| Title |
|
||||||
I have tested this item ✅ successfully on 0818105
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41942.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
Release Blocker
PR-5.0-dev
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41942.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-09-27 07:57:23 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
|
||
thanks
I have tested this item ✅ successfully on 0818105
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41942.