User tests: Successful: Unsuccessful:
Fixes bug caused by #38914 which breaks table backups.
Table backups in installation are fixed with this patch
Note there might be a similar bug https://github.com/joomla/joomla-cms/blob/4.3-dev/installation/src/Helper/DatabaseHelper.php#L321 here where we reset the session objects. But I can't see us reusing the options so it's probably fine? Definitely needs another review
Steps to replicate the bug (thanks @brianteeman !!)
Someone should probably validate that this doesn't break the cli installer too.
Error appears. null
if you haven't got #41941 applied or a big list of errors if you do
No errors and tables backed up
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
Category | ⇒ | Installation |
Status | New | ⇒ | Pending |
Title |
|
I have tested this item ✅ successfully on 0818105
Status | Pending | ⇒ | Ready to Commit |
Labels |
Added:
Release Blocker
PR-5.0-dev
|
RTC
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-09-27 07:57:23 |
Closed_By | ⇒ | HLeithner | |
Labels |
Added:
?
|
thanks
I have tested this item ✅ successfully on 0818105
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41942.