User tests: Successful: Unsuccessful:
Improves the UX of the installer when an installation fails in some edge cases.
Steps to replicate the bug (thanks @brianteeman !!)
In such a case what happens is the errors are enqueued through enqueueMessage and the progress bar stops, gives a null error message and gives me no way to continue. The only way to bail is to refresh and refill out the passwords all over again (the rest of the data is thankfully stored in the session).
You can only see the errors in the network request.
The user form is shown to the user and the progress bar is hidden. This allows the user to resubmit their data after fixing any required items without needing to fill out the form all over again.
Sample screenshot of after.
Note this doesn't fix the error. Just how we handle the errors. Next step is to figure out the root cause.
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
Category | ⇒ | JavaScript Installation |
Status | New | ⇒ | Pending |
Steps to replicate the bug
⭐ amazing! I've been moaning about this in maintainers chat for nearly a month but it seemed to be triggering on git pull's periodically. It was only this morning it twigged it was just because first thing I do is run a git pull and my cookie from previous day's had expired. Then I actually had enough to start dev'ing a fix.
Next step after this one is to fix the underlying bug
As soon as I saw that you were using jos_ I could see what the problem was. If I was to guess further then the bug is in the code that creates the bak_ tables
is there a file missing?
I am getting this error in the console
Error in DB Check Endpoint
onSuccess @ setup.js?c70aefa4f91b20a6b13d12fa12c84add:105
n.onreadystatechange @ core.min.js?c70aefa4f91b20a6b13d12fa12c84add:1
XMLHttpRequest.send (async)
r @ core.min.js?c70aefa4f91b20a6b13d12fa12c84add:1
e.request @ core.min.js?c70aefa4f91b20a6b13d12fa12c84add:1
Joomla.checkDbCredentials @ setup.js?c70aefa4f91b20a6b13d12fa12c84add:92
Joomla.checkInputs @ setup.js?c70aefa4f91b20a6b13d12fa12c84add:72
(anonymous) @ setup.js?c70aefa4f91b20a6b13d12fa12c84add:219
Not for me? I mean none of the code here isn't already in the file for other requests. Just specifically on this request it's missing
https://github.com/joomla/joomla-cms/blob/5.0-dev/installation/template/js/setup.js#L105 suggests you're not getting valid JSON back. Can you show me your network tab?
I have tested this item ✅ successfully on 31b1f68
I have tested this item ✅ successfully on 31b1f68
worked this morning - must have missed something last night
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-09-27 07:56:36 |
Closed_By | ⇒ | HLeithner | |
Labels |
Added:
Release Blocker
PR-5.0-dev
|
thank you
found the cause of the problem - just doing one more test to confirm