NPM Resource Changed bug PR-4.4-dev Pending

User tests: Successful: Unsuccessful:

avatar obuisard
obuisard
24 Sep 2023

Pull Request for Issue #40374 and issues encountered while running Cypress.
First fixed for 5.0 until it turned out it was a general issue already spotted in 4.3.

Summary of Changes

The javascript fails because the cookie that records the state of the sidebar is not yet present.

image

Testing Instructions

On a fresh install, upon login, check the browser console.
No javascript error should appear.

Thank you Richard @richard67 for suggesting this fix.

Actual result BEFORE applying this Pull Request

The error shows in the console.

Expected result AFTER applying this Pull Request

No longer an error.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 24 Sep 2023
Category JavaScript Repository NPM Change
avatar obuisard obuisard - open - 24 Sep 2023
avatar obuisard obuisard - change - 24 Sep 2023
Status New Pending
avatar obuisard obuisard - change - 24 Sep 2023
The description was changed
avatar obuisard obuisard - edited - 24 Sep 2023
avatar obuisard obuisard - change - 24 Sep 2023
Labels Added: NPM Resource Changed bug PR-4.4-dev
avatar richard67
richard67 - comment - 25 Sep 2023

I'd really like to test this PR, but I can't reproduce the issue. I don't get that javascript error in my browser console, neither with a 4.40-derv nor with a 5.0-dev on the first login after a new installation. Maybe it depends on the browser? I've used Firefox 117.0.1 (64-Bit) for Windows. Or maybe it depends on browser settings or addons?

avatar laoneo
laoneo - comment - 25 Sep 2023

You can also clear the cookies and then put it into the mobile view of your browsers dev tools.

avatar richard67 richard67 - test_item - 25 Sep 2023 - Tested successfully
avatar richard67
richard67 - comment - 25 Sep 2023

I have tested this item ✅ successfully on c9a517b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41909.

avatar richard67
richard67 - comment - 25 Sep 2023

You can also clear the cookies and then put it into the mobile view of your browsers dev tools.

@laoneo Thanks for the hint. That helped to reproduce it.

avatar laoneo laoneo - change - 26 Sep 2023
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-09-26 05:43:45
Closed_By laoneo
avatar laoneo laoneo - close - 26 Sep 2023
avatar laoneo laoneo - merge - 26 Sep 2023
avatar laoneo
laoneo - comment - 26 Sep 2023

Thanks!

Add a Comment

Login with GitHub to post a comment