[#41908] - [5.0] Remove 'track_errors' and $php_errormsg
- Fixed in Code Base
- 25 Sep 2023
- Medium
- Build: 5.0-dev
- # 41908
- Diff
- Denitz:remove_track_errors
User tests: Successful: Unsuccessful:
Pull Request for Issue #41889 #25789 #17856 #33185
Summary of Changes
Remove suppressing of methods which produce E_WARNING and necessity of catching the error in deprecated $php_errormsg.
I didn't update Joomla\CMS\Filesystem\Stream because it's deprecated since 4.4
Testing Instructions
Try to parse language string with errors (with enabled Joomla debug + language debug)
Try to install the package from invalid URL
Actual result BEFORE applying this Pull Request
See native Joomla error messages in installer and debug errors in language debug bar.
Expected result AFTER applying this Pull Request
See the same errors/messages.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Status | New | ⇒ | Pending |
| Labels |
Added:
PR-5.0-dev
|
||
| Labels |
Added:
Release Blocker
bug
|
||
@HLeithner All done.
thanks I merged this for now so we have it in beta3. CI test should at least check the language parsing part.
thanks
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-09-25 14:50:16 |
| Closed_By | ⇒ | HLeithner |
I'm not sure if it's the right approach but it looks ok to me. @laoneo @wilsonge @Fedik opinions on this?