Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#41763] - [5] admin module deprecation

PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
15 Sep 2023

Pull Request for Issue #41605

Summary of Changes

do the check only if not null

Testing Instructions

see #41605
php 8.1

Actual result BEFORE applying this Pull Request

deprecation

Expected result AFTER applying this Pull Request

no more deprecation

avatar joomla-cms-bot joomla-cms-bot - change - 15 Sep 2023
Category ⇒ Libraries
avatar alikon alikon - open - 15 Sep 2023
avatar alikon alikon - change - 15 Sep 2023
Status New ⇒ Pending
ec76a9e 15 Sep 2023 avatar alikon cs
avatar alikon alikon - change - 15 Sep 2023
Labels Added: PR-5.0-dev
b75b6b2 16 Sep 2023 avatar alikon oops
avatar HLeithner
HLeithner - comment - 16 Sep 2023

I would say an !empty would fit better here at least use !== null

df7a053 17 Sep 2023 avatar alikon empty
avatar HLeithner HLeithner - change - 17 Sep 2023
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2023-09-17 20:40:30
Closed_By ⇒ HLeithner
avatar HLeithner HLeithner - close - 17 Sep 2023
avatar HLeithner HLeithner - merge - 17 Sep 2023
avatar HLeithner
HLeithner - comment - 17 Sep 2023

thanks

Add a Comment

Login with GitHub to post a comment