Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#41762] - [5.0] guided tours identical expressions

PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
15 Sep 2023

it is obviously incorrect to test for "a" or "a"

I have assumed based on a few lines previous that this PR is what was intended. If not then the second expression should be removed.

@GeraintEdwards @obuisard

Testing Instructions

code review

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 15 Sep 2023
Category ⇒ Administration
avatar brianteeman brianteeman - open - 15 Sep 2023
avatar brianteeman brianteeman - change - 15 Sep 2023
Status New ⇒ Pending
avatar GeraintEdwards
GeraintEdwards - comment - 15 Sep 2023

Good spot @brianteeman

I have reviewed the code change - your changes are patently correct.

avatar HLeithner HLeithner - change - 16 Sep 2023
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2023-09-16 12:51:10
Closed_By ⇒ HLeithner
Labels Added: PR-5.0-dev
avatar HLeithner HLeithner - close - 16 Sep 2023
avatar HLeithner HLeithner - merge - 16 Sep 2023

Add a Comment

Login with GitHub to post a comment