Feeling Lucky
?
PR-5.0-dev
[#41764] - [5.0] toolbar cancel or close button
- Fixed in Code Base
- 15 Sep 2023
- Medium
- Build: 5.0-dev
- # 41764
- Diff
- brianteeman:cancel_close_toolbar
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
The convention is that when it is a NEW item then its a cancel button and when editing an item its a close button.
During the updates in #39537 it looks like @wilsonge missed a few changes etc
Testing Instructions
For the components updated check that it correctly uses the close or cancel button text
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Administration com_categories com_contact com_fields com_finder com_languages |
| Status | New | ⇒ | Pending |
Quy
- comment
- 15 Sep 2023
I have tested this item ✅ successfully on 306dc4e
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41764.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
PR-5.0-dev
|
||
Quy
- comment
- 15 Sep 2023
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41764.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-09-15 16:24:12 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
wilsonge
- comment
- 15 Sep 2023
Thanks!
brianteeman
- comment
- 15 Sep 2023
Thank you
I have tested this item ✅ successfully on 306dc4e
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41764.