[#41632] - [5.0] Modal field for MenutypeField
- Fixed in Code Base
- 12 Sep 2023
- Medium
- Build: 5.0-dev
- # 41632
- Diff
- Fedik:popup-menutype
User tests: Successful: Unsuccessful:
Summary of Changes
Changing MenutypeField field to use new modal dialog.
It may not hit 5.0, but in future will need to update anyway.
Testing Instructions
Run npm install
Create/Edit menu item, change the menu type.
Actual result BEFORE applying this Pull Request
Works with old bs modal
Expected result AFTER applying this Pull Request
Works with new dialog.
Link to documentations
Please select:
- Documentation link for docs.joomla.org:
- No documentation changes for docs.joomla.org needed
- Pull Request link for manual.joomla.org: as part of joomla/Manual#178
- No documentation changes for manual.joomla.org needed
Reference:
joomla-cms-bot
- | Category | ⇒ | Administration com_menus JavaScript Repository NPM Change |
| Status | New | ⇒ | Pending |
| Labels |
Added:
Feature
NPM Resource Changed
PR-5.0-dev
|
||
New Menu Item has component preset
Hm, no, something wrong. Need to check.
| Category | Administration com_menus JavaScript Repository NPM Change | ⇒ | Administration com_menus JavaScript Repository NPM Change Layout Libraries |
I have tested this item ✅ successfully on 7efeb34
It works - I see the different types of dialog. But it was my understanding that iframes are not recommended by some authorities. Has the wind changed?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41632.
I have tested this item
Sorry, I made litle more change, please try again.
It still should be the same, but just to be sure. Thanks!
But it was my understanding that iframes are not recommended by some authorities
It depend for what it is used and when ?
I have tested this item ✅ successfully on b52d884
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41632.
HLeithner
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-09-12 18:19:12 |
| Closed_By | ⇒ | HLeithner |
Not sure about this! Applied patch and npm install. New Menu Item has component preset in the Menu Item Type field and a Clear button at the end. Is that intended? Otherwise it works as expected.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41632.