Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#41633] - [5.0] Do not force old XTD buttons to use new modal

? Release Blocker bug PR-5.0-dev b/c break Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
7 Sep 2023

Summary of Changes

In #40202 was added code that allows to show old XTD buttons in new Dialog, when $button->modal = true.
Hovewer this does not work good.
I removing this part here.
Now a new modal will work only when button explicitly set $button->action = 'modal'.

Testing Instructions

Edit Contact XTD button

joomla-cms/plugins/editors-xtd/contact/src/Extension/Contact.php

Line 60 in aa52c06

$button->action = 'modal';

Change to:

$button->modal = true;

Go to article ediiting and click this button.

Actual result BEFORE applying this Pull Request

You get a new Dialog modal

Expected result AFTER applying this Pull Request

You get BS modal.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org:
  • No documentation changes for manual.joomla.org needed

Reference:

avatar joomla-cms-bot joomla-cms-bot - change - 7 Sep 2023
Category ⇒ Layout Front End Plugins
avatar Fedik Fedik - open - 7 Sep 2023
avatar Fedik Fedik - change - 7 Sep 2023
Status New ⇒ Pending
avatar Fedik Fedik - change - 7 Sep 2023
The description was changed
avatar Fedik Fedik - edited - 7 Sep 2023
avatar Fedik Fedik - change - 7 Sep 2023
The description was changed
avatar Fedik Fedik - edited - 7 Sep 2023
avatar Fedik Fedik - change - 7 Sep 2023
The description was changed
avatar Fedik Fedik - edited - 7 Sep 2023
avatar Fedik Fedik - change - 7 Sep 2023
The description was changed
avatar Fedik Fedik - edited - 7 Sep 2023
avatar joomla-cms-bot joomla-cms-bot - change - 7 Sep 2023
Category Layout Front End Plugins ⇒ Layout Front End Plugins Unit Tests
avatar Fedik Fedik - change - 7 Sep 2023
Labels Added: Release Blocker bug PR-5.0-dev b/c break
avatar Ruud68
Ruud68 - comment - 7 Sep 2023

Works! but please note this: #40202 (comment)

avatar ceford ceford - test_item - 7 Sep 2023 - Tested successfully
avatar ceford
ceford - comment - 7 Sep 2023

I have tested this item ✅ successfully on be649dc

For clarity for other testers: in Article Edit it is the CMS Content / Contact button to be selected.

I see the slight difference in appearance of the two layouts and the different implementation. Both work fine in selecting a Contact to insert into an article.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41633.

avatar Fedik Fedik - change - 13 Sep 2023
Labels Added: ?
avatar HLeithner HLeithner - change - 17 Sep 2023
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2023-09-17 17:32:56
Closed_By ⇒ HLeithner
avatar HLeithner HLeithner - close - 17 Sep 2023
avatar HLeithner HLeithner - merge - 17 Sep 2023
avatar HLeithner
HLeithner - comment - 17 Sep 2023

Works! but please note this: #40202 (comment)

@Ruud68 thanks for your comment I answered it in the issue maybe not the ideal solution for you but hard to solve all issues without resources.

thanks @Fedik and testers

Add a Comment

Login with GitHub to post a comment