Feature RTC PR-5.1-dev Pending

User tests: Successful: Unsuccessful:

avatar artur-stepien
artur-stepien
6 Sep 2023

This adds the support for Subcategory Levels in Category tab of List Contacts in a Category view. Currently, this setting is not applied in the query, so using it will not allow viewing all contacts in the category and its subcategories.

Summary of Changes

Added state entry and query filter for this parameter.

Testing Instructions

  • Create a contact category called All contacts
  • Create a contact category called A and set the parent as All contacts
  • Create a contact category called B and set the parent as All contacts
  • Create contact Contact from A and place it in A category
  • Create contact Contact from B and place it in B category
  • Create a menu item of type List Contacts in a Category, chose category All contacts and make sure in Category tab Subcategory Levels is set to All or any positive value
  • Save and head to the recently created menu item in front-end

Actual result BEFORE applying this Pull Request

There should be no contacts displayed in this view.

Expected result AFTER applying this Pull Request

All contacts from category A and B will be displayed.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 6 Sep 2023
Category Front End com_contact
avatar artur-stepien artur-stepien - open - 6 Sep 2023
avatar artur-stepien artur-stepien - change - 6 Sep 2023
Status New Pending
avatar Quy
Quy - comment - 7 Sep 2023
avatar artur-stepien
artur-stepien - comment - 7 Sep 2023

Please fix phpcs: https://ci.joomla.org/joomla/joomla-cms/69748/1/8

Yeah, but what is it complaining about. The lack of alignment between = signs?

avatar artur-stepien artur-stepien - change - 7 Sep 2023
Labels Added: PR-4.3-dev
avatar ceford ceford - test_item - 25 Sep 2023 - Tested successfully
avatar ceford
ceford - comment - 25 Sep 2023

I have tested this item ✅ successfully on 696b25d

Without the patch I see just the Subcategories list. With the patch I see the actual contacts in Categories A and B.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41618.

avatar artur-stepien
artur-stepien - comment - 25 Sep 2023

@Quy Do you know why the test is failing?

avatar HLeithner
HLeithner - comment - 30 Sep 2023

This pull request has been automatically rebased to 5.1-dev.

avatar artur-stepien
artur-stepien - comment - 20 Oct 2023

@HLeithner Do you know why this issue fails build? Its a bug that affects one of clients websites and I see no reply to the question.

avatar HLeithner HLeithner - change - 20 Oct 2023
Labels Added: Feature PR-5.1-dev
Removed: PR-4.3-dev
avatar HLeithner
HLeithner - comment - 20 Oct 2023

I updated the branch, this should retrigger a ci run

avatar viocassel viocassel - test_item - 18 Nov 2023 - Tested successfully
avatar viocassel
viocassel - comment - 18 Nov 2023

I have tested this item ✅ successfully on 8ececc4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41618.

avatar Quy Quy - alter_testresult - 20 Nov 2023 - ceford: Tested successfully
avatar Quy Quy - change - 20 Nov 2023
Status Pending Ready to Commit
avatar Quy
Quy - comment - 20 Nov 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41618.

avatar LadySolveig LadySolveig - change - 15 Dec 2023
Labels Added: RTC
avatar Razzo1987 Razzo1987 - close - 24 Jan 2024
avatar Razzo1987 Razzo1987 - merge - 24 Jan 2024
avatar Razzo1987 Razzo1987 - change - 24 Jan 2024
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-01-24 20:43:59
Closed_By Razzo1987
avatar Razzo1987
Razzo1987 - comment - 24 Jan 2024

Thanks

Add a Comment

Login with GitHub to post a comment