Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#41619] - [5.0] Include Codemirror Markdown support

? NPM Resource Changed PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
6 Sep 2023

Pull Request for Issue # .

Summary of Changes

Add markdown mode support for Codemirror.
Any other modes need to be inlcuded by default?

Testing Instructions

Apply patch. Run npm install
Add editor field in mod_custom:

<field name="editor_test" type="editor" label="Editor" 
  syntax="markdown" editor="codemirror" filter="safehtml"/>

Actual result BEFORE applying this Pull Request

No markdown support

Expected result AFTER applying this Pull Request

Markdown works

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org:
  • No documentation changes for manual.joomla.org needed

Reference:

avatar joomla-cms-bot joomla-cms-bot - change - 6 Sep 2023
Category ⇒ NPM Change
avatar Fedik Fedik - open - 6 Sep 2023
avatar Fedik Fedik - change - 6 Sep 2023
Status New ⇒ Pending
avatar Fedik Fedik - change - 6 Sep 2023
Title
…
[5.0] Include codemirror MD support
[5.0] Include Codemirror Markdown support
avatar Fedik Fedik - edited - 6 Sep 2023
avatar brianteeman
brianteeman - comment - 6 Sep 2023

Not sure this is working as expected

I expect there to be syntax highlighting as shown in the demo https://codemirror.net/5/mode/markdown/index.html but if i paste the text from the demo then there is none and its just the same as without the changes in this pr

avatar ceford ceford - test_item - 6 Sep 2023 - Tested successfully
avatar ceford
ceford - comment - 6 Sep 2023

I have tested this item ✅ successfully on 1566c04

Syntax highlighting has a little less contrast than in CodeMirror 5 but I guess that might be fixable later. Otherwise it works fine. Should the Test Instructions be npm ci rather than npm install? Anyway - I am happy - thank you.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41619.

avatar brianteeman
brianteeman - comment - 6 Sep 2023

@ceford you do realise that you can write markdown in tinymce as well if you enable the option in the plugin

avatar brianteeman brianteeman - test_item - 6 Sep 2023 - Tested successfully
avatar brianteeman
brianteeman - comment - 6 Sep 2023

I have tested this item ✅ successfully on 1566c04

sorry - works fine

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41619.

avatar Quy Quy - change - 6 Sep 2023
Status Pending ⇒ Ready to Commit
Labels Added: NPM Resource Changed PR-5.0-dev
avatar Quy
Quy - comment - 6 Sep 2023

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41619.

avatar HLeithner HLeithner - change - 6 Sep 2023
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2023-09-06 20:14:11
Closed_By ⇒ HLeithner
Labels Added: ?
avatar HLeithner HLeithner - close - 6 Sep 2023
avatar HLeithner HLeithner - merge - 6 Sep 2023
avatar HLeithner
HLeithner - comment - 6 Sep 2023

thanks

Add a Comment

Login with GitHub to post a comment