Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#41617] - [4.4] Fix deprecated null warning, in ModuleAdapter: Deprecated: PDO::quote(): Passing null to parameter 1

? bug PR-4.4-dev Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
6 Sep 2023

Pull Request for Issue # .

Summary of Changes

Same as #41614 but for j4

Fix deprecation for ModuleAdapter
Deprecated: PDO::quote(): Passing null to parameter 1 ($string) of type string is deprecated
And Patch::clean() on null.

Testing Instructions

Enable error_reaporting to maximum
Try install any module.

Actual result BEFORE applying this Pull Request

An error message Unexpected token ...
Open Browser console, in network tab for the POST request will be full deprecation message:
Deprecated: PDO::quote(): Passing null to parameter 1 ($string) of type string is deprecated for line

joomla-cms/libraries/src/Table/Module.php

Line 210 in f19e3f3

$this->ordering = $this->getNextOrder($this->_db->quoteName('position') . ' = ' . $this->_db->quote($this->position));

Expected result AFTER applying this Pull Request

Module installed without error.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org:
  • No documentation changes for manual.joomla.org needed
avatar joomla-cms-bot joomla-cms-bot - change - 6 Sep 2023
Category ⇒ Libraries
avatar Fedik Fedik - open - 6 Sep 2023
avatar Fedik Fedik - change - 6 Sep 2023
Status New ⇒ Pending
avatar Fedik Fedik - change - 6 Sep 2023
Title
…
Fix deprecated null warning, in ModuleAdapter: Deprecated: PDO::quote(): Passing null to parameter 1
[4.x] Fix deprecated null warning, in ModuleAdapter: Deprecated: PDO::quote(): Passing null to parameter 1
avatar Fedik Fedik - edited - 6 Sep 2023
avatar alikon alikon - test_item - 8 Sep 2023 - Tested successfully
avatar alikon
alikon - comment - 8 Sep 2023

I have tested this item ✅ successfully on 617cb4e

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41617.

avatar ceford
ceford - comment - 25 Sep 2023

Probably my misunderstanding - I do not see a deprecation warning when installing a module via System / Install Extensions. I have Debug Yes and Error Reporting Maximum. This is with a clone of joomla-cms and 4.3-dev checked out.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41617.

avatar Fedik
Fedik - comment - 25 Sep 2023

@ceford sorry, I forgot to add, it for PHP 8

avatar Fedik Fedik - change - 28 Sep 2023
Title
…
[4.x] Fix deprecated null warning, in ModuleAdapter: Deprecated: PDO::quote(): Passing null to parameter 1
[4.4] Fix deprecated null warning, in ModuleAdapter: Deprecated: PDO::quote(): Passing null to parameter 1
avatar Fedik Fedik - edited - 28 Sep 2023
avatar martin-zw martin-zw - test_item - 28 Sep 2023 - Tested successfully
avatar martin-zw
martin-zw - comment - 28 Sep 2023

I have tested this item ✅ successfully on 617cb4e

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41617.

avatar Quy Quy - change - 28 Sep 2023
Status Pending ⇒ Ready to Commit
Labels Added: bug PR-4.4-dev
avatar Quy
Quy - comment - 28 Sep 2023

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41617.

avatar Quy Quy - change - 28 Sep 2023
Labels Added: ?
avatar MacJoom MacJoom - change - 28 Sep 2023
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2023-09-28 17:45:41
Closed_By ⇒ MacJoom
avatar MacJoom MacJoom - close - 28 Sep 2023
avatar MacJoom MacJoom - merge - 28 Sep 2023

Add a Comment

Login with GitHub to post a comment