Joomla! Issue Tracker | Joomla! CMS #41614 - [5.0] Fix deprecated null warning, in ModuleAdapter: Deprecated: PDO::quote(): Passing null to parameter 1

bug PR-5.0-dev

Closed
6 Sep 2023
Medium
Build: 5.0-dev
# 41614
Diff
Fedik:installer-mod-fix

Pending

User tests: Successful: Unsuccessful:

Fedik
6 Sep 2023

Summary of Changes

Fix deprecation for ModuleAdapter
Deprecated: PDO::quote(): Passing null to parameter 1 ($string) of type string is deprecated
And Patch::clean() on null.

Testing Instructions

Enable error_reaporting to maximum
Try install any module.

Actual result BEFORE applying this Pull Request

An error message Unexpected token ...
Open Browser console, in network tab for the POST request will be full deprecation message:
Deprecated: PDO::quote(): Passing null to parameter 1 ($string) of type string is deprecated for line

joomla-cms/libraries/src/Table/Module.php

Line 210 in f19e3f3

    
           $this->ordering = $this->getNextOrder($this->_db->quoteName('position') . ' = ' . $this->_db->quote($this->position));

Expected result AFTER applying this Pull Request

Module installed without error.

Link to documentations

Please select:

Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed

9f0512a 6 Sep 2023

Fix deprecated null, in ModuleAdapter

joomla-cms-bot - change - 6 Sep 2023

Category

⇒

Libraries

Fedik - open - 6 Sep 2023

Fedik - change - 6 Sep 2023

Status

New

⇒

Pending

wilsonge - comment - 6 Sep 2023

This should probably be targeted at 4.3 dev

Fedik - comment - 6 Sep 2023

Yeah, makes sense,
I got it while trying 5.0 and made automaticaly to 5.0 ?
I will redo

Fedik - comment - 6 Sep 2023

Okay, there it is #41617

Fedik - close - 6 Sep 2023