[#41615] - Fix double border on toolbar
- Fixed in Code Base
- 7 Sep 2023
- Medium
- Build: 5.0-dev
- # 41615
- Diff
- wilsonge:fix/toolbar-border
User tests: Successful: Unsuccessful:
Pull Request for Issue #41571 (Partial).
Summary of Changes
Fixes the save button toolbar double border when editing and also fixes an undefined variable in the tabs element too that invisible but still was a technical bug. bg-color was a bad copy paste from quickicons (where it was correct specifically ther) and should have been body-bg
For the toolbar I’ve been consistent with the original dark mode approach and removed the background just hiding the extra border. But if this causes any unexpected issues I’ll revert to using body-bg there too.
Testing Instructions
Check images from original issue specifically related to the toolbar icon. Should be the same as the Joomla 4.x layout after patch applied
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Repository NPM Change |
| Status | New | ⇒ | Pending |
That was the view I was testing for this patch :/ on phone again but will drop a screenshot in later to prove I actually did test things ?
| Labels |
Added:
NPM Resource Changed
PR-5.0-dev
|
||
OK I give up. I guess I didn't hit compile after the last time I changed it. Should be fixed.
I have tested this item ✅ successfully on 725210d
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41615.
I have tested this item ✅ successfully on 3951f09
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41615.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41615.
HLeithner
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-09-07 08:25:31 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
|
||
:)