[#41613] - Update ListPlugin.php fix API
- Closed
- 18 Sep 2023
- Medium
- Build: 4.3-dev
- # 41613
- Diff
- antonbag:patch-3
User tests: Successful: Unsuccessful:
Added two checkers:
if empty
if is array.
The current file gives error 500 in api.
Pull Request for Issue # .
Summary of Changes
//added return on empty
if (empty($field->value)) {
return;
}
//API
//if api and array splits values
if (is_array($field->value)) {
foreach ($field->value as $key => $value) {
$field->apivalue[$value] = $options[$value];
}
} else {
//default values
$field->apivalue[$field->value] = $options[$field->value];
}
Testing Instructions
Actual result BEFORE applying this Pull Request
ERROR 500 on empty values with api query
Expected result AFTER applying this Pull Request
if multiple:
"name-of-list-field": {
"text": "value",
"text": "value",
...
}
if single:
"name-of-list-field": {
"text": "value"
}
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Status | New | ⇒ | Pending |
| Labels |
Added:
PR-4.3-dev
|
||
Please test PR #41777 which that also includes radio buttons.
Tested and working perfect!
@antonbag Could you mark your test result in the issue tracker? For this, just go to https://issues.joomla.org/tracker/joomla-cms/41777 , then use the blue "Test this" button at the top left corner, then select your test result (success) and submit. Thanks in advance.
alikon
- | Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-09-18 12:02:03 |
| Closed_By | ⇒ | alikon | |
| Labels |
Added:
?
|
||
Please test PR #41777 which that also includes radio buttons.