Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#41592] - [5.0] TinyMCE plugins

NPM Resource Changed bug PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
4 Sep 2023

Pull Request for Issue # .

Summary of Changes

When displaying the help page inside tinymce there is a list of the plugins being used and links to more information
This PR updates the three external plugins with a correct name and a link to joomla.org. The link itself can always be updated to a specific page in the future.

Testing Instructions

Enable the help btton in the tinymce plugin

image

In an article select the help button

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 4 Sep 2023
Category ⇒ JavaScript Repository NPM Change
avatar brianteeman brianteeman - open - 4 Sep 2023
avatar brianteeman brianteeman - change - 4 Sep 2023
Status New ⇒ Pending
avatar brianteeman brianteeman - change - 4 Sep 2023
The description was changed
avatar brianteeman brianteeman - edited - 4 Sep 2023
avatar brianteeman brianteeman - change - 4 Sep 2023
The description was changed
avatar brianteeman brianteeman - edited - 4 Sep 2023
avatar brianteeman brianteeman - change - 4 Sep 2023
The description was changed
avatar brianteeman brianteeman - edited - 4 Sep 2023
avatar brianteeman brianteeman - change - 4 Sep 2023
The description was changed
avatar brianteeman brianteeman - edited - 4 Sep 2023
avatar brianteeman brianteeman - change - 4 Sep 2023
Labels Added: NPM Resource Changed PR-5.0-dev
avatar wilsonge
wilsonge - comment - 4 Sep 2023

Should these not be translatable strings as they're being rendered?

avatar brianteeman
brianteeman - comment - 4 Sep 2023

Should these not be translatable strings as they're being rendered?

i dont think any of the strings on that tab are translated

avatar Fedik Fedik - test_item - 5 Sep 2023 - Tested successfully
avatar Fedik
Fedik - comment - 5 Sep 2023

I have tested this item ✅ successfully on 39561f8

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41592.

avatar wilsonge wilsonge - change - 6 Sep 2023
Labels Added: bug
avatar ceford
ceford - comment - 12 Sep 2023

I must be doing something wrong. With 5.0.0-beta-2 I apply the patch and npm ci - I get a different set of Help links but not like in the illustration:

screen shot 2023-09-12 at 04 37 56

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41592.

avatar ceford ceford - test_item - 12 Sep 2023 - Tested successfully
avatar ceford
ceford - comment - 12 Sep 2023

I have tested this item ✅ successfully on 159deff

For my previous test I neglected to bring my clone up to data. I now see the links as in the illustration.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41592.

avatar richard67 richard67 - alter_testresult - 12 Sep 2023 - Fedik: Tested successfully
avatar HLeithner HLeithner - change - 12 Sep 2023
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2023-09-12 11:20:14
Closed_By ⇒ HLeithner
avatar HLeithner HLeithner - close - 12 Sep 2023
avatar HLeithner HLeithner - merge - 12 Sep 2023
avatar ceford ceford - test_item - 12 Sep 2023 - Not tested
avatar ceford
ceford - comment - 12 Sep 2023

I have not tested this item.

For my previous test I neglected to bring my clone up to data. I now see the links as in the illustration.

Actually - two new links point to docs.joomla.org - surely that should be fixed before approval.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41592.

Add a Comment

Login with GitHub to post a comment