PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
4 Sep 2023

Summary of Changes

Moves the category feed view from extending the base html class to abstract view which is a non-impacting b/c break. Justification being that we aren't using any of the html methods and it's not a HTML view - so it's a good example of extending abstractview.

This is pulled out of the wider view rework in #38937

Whilst I'm at it add class definitions for two missing properties

Testing Instructions

Check feed view for a category works before and after the patch in the same way (output should be identical)

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org: joomla/Manual@6457c2e

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 4 Sep 2023
Category Unit Tests Repository Administration com_admin SQL
avatar wilsonge wilsonge - open - 4 Sep 2023
avatar wilsonge wilsonge - change - 4 Sep 2023
Status New Pending
avatar wilsonge wilsonge - change - 4 Sep 2023
Labels Added: ? PR-4.3-dev
avatar joomla-cms-bot joomla-cms-bot - change - 4 Sep 2023
Category Unit Tests Repository Administration com_admin SQL Libraries
avatar HLeithner HLeithner - close - 12 Sep 2023
avatar HLeithner HLeithner - merge - 12 Sep 2023
avatar HLeithner HLeithner - change - 12 Sep 2023
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-09-12 18:28:02
Closed_By HLeithner
Labels Added: PR-5.0-dev
Removed: ? PR-4.3-dev
avatar HLeithner
HLeithner - comment - 12 Sep 2023

thanks, a feed is not html

avatar wilsonge wilsonge - change - 12 Sep 2023
The description was changed
avatar wilsonge wilsonge - edited - 12 Sep 2023

Add a Comment

Login with GitHub to post a comment