Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#41477] - Fix calendar positioning

? NPM Resource Changed bug PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar MagnusSinger
MagnusSinger
26 Aug 2023

Pull Request for Issue #40577.

Summary of Changes

Depending on the scroll position of the page, the calendar gets displayed above or below the field, even when the scroll position changes

Testing Instructions

Open a calendar, scroll on the page and open the calendar again. Depending on the scroll position, it should change if the calendar opens above or below the field

Actual result BEFORE applying this Pull Request

Sometimes, the calendar got stuck above or below the field when you changed the scroll position

Expected result AFTER applying this Pull Request

It now gets changed when you scroll

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 26 Aug 2023
Category ⇒ JavaScript Repository NPM Change
avatar MagnusSinger MagnusSinger - open - 26 Aug 2023
avatar MagnusSinger MagnusSinger - change - 26 Aug 2023
Status New ⇒ Pending
avatar fancyFranci fancyFranci - test_item - 26 Aug 2023 - Tested successfully
avatar fancyFranci
fancyFranci - comment - 26 Aug 2023

I have tested this item ✅ successfully on 5765385

It works in Firefox. I used the contact creation form for testing.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41477.

avatar richard67
richard67 - comment - 26 Aug 2023

@MagnusSinger Does this also solve the other 2 issues #38443 and #38346 ?

avatar N6REJ N6REJ - test_item - 26 Aug 2023 - Tested successfully
avatar N6REJ
N6REJ - comment - 26 Aug 2023

I have tested this item ✅ successfully on 5765385

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41477.

avatar richard67 richard67 - change - 26 Aug 2023
Status Pending ⇒ Ready to Commit
Labels Added: NPM Resource Changed PR-4.3-dev
avatar richard67
richard67 - comment - 26 Aug 2023

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41477.

avatar flo-the-cat flo-the-cat - test_item - 26 Aug 2023 - Tested successfully
avatar flo-the-cat
flo-the-cat - comment - 26 Aug 2023

I have tested this item ✅ successfully on 5765385

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41477.

avatar brianteeman
brianteeman - comment - 27 Aug 2023

@MagnusSinger Does this also solve the other 2 issues #38443 and #38346 ?

It does not solve #38443 or #38346

avatar MagnusSinger
MagnusSinger - comment - 28 Aug 2023

@MagnusSinger Does this also solve the other 2 issues #38443 and #38346 ?

It does not solve #38443 or #38346

No as this is just a fix for the general calendar positioning, the other special cases might need additional PRs?

avatar obuisard obuisard - close - 28 Aug 2023
avatar obuisard obuisard - merge - 28 Aug 2023
avatar obuisard obuisard - change - 28 Aug 2023
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2023-08-28 16:30:31
Closed_By ⇒ obuisard
Labels Added: ? bug
avatar obuisard
obuisard - comment - 28 Aug 2023

Thank you Magnus @MagnusSinger for the PR!

Add a Comment

Login with GitHub to post a comment