? NPM Resource Changed bug PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar MagnusSinger
MagnusSinger
26 Aug 2023

Pull Request for Issue #40096.

Summary of Changes

Every choicesJS input has a min width attribute depending on its placeholder characters. This can be overwritten by just setting the max width of the parent to 100%

Testing Instructions

Open a page with a choicesJS input (for example the edit article page) and shrink the viewport, the input should adapt

Actual result BEFORE applying this Pull Request

The input moved out of the viewport

Expected result AFTER applying this Pull Request

The input stays in the viewport

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 26 Aug 2023
Category Repository NPM Change
avatar MagnusSinger MagnusSinger - open - 26 Aug 2023
avatar MagnusSinger MagnusSinger - change - 26 Aug 2023
Status New Pending
avatar MacJoom MacJoom - test_item - 26 Aug 2023 - Tested successfully
avatar MacJoom
MacJoom - comment - 26 Aug 2023

I have tested this item ✅ successfully on a97e0a0

on 4.3.4 - after applying patch and composer install - go to article edit and look for the dropdowns on the right side (look before and after)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41478.

avatar brianteeman brianteeman - test_item - 27 Aug 2023 - Tested successfully
avatar brianteeman
brianteeman - comment - 27 Aug 2023

I have tested this item ✅ successfully on a97e0a0


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41478.

avatar Quy Quy - change - 2 Sep 2023
Status Pending Ready to Commit
Labels Added: NPM Resource Changed PR-4.3-dev
avatar Quy
Quy - comment - 2 Sep 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41478.

avatar Quy Quy - change - 2 Sep 2023
Labels Added: ?
avatar Quy Quy - change - 4 Sep 2023
Labels Added: bug
avatar obuisard obuisard - change - 13 Sep 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-09-13 15:29:57
Closed_By obuisard
avatar obuisard obuisard - close - 13 Sep 2023
avatar obuisard obuisard - merge - 13 Sep 2023
avatar obuisard
obuisard - comment - 13 Sep 2023

Thank you Magnus @MagnusSinger for the PR!

Add a Comment

Login with GitHub to post a comment