[#41442] - [5.0] Guidedtour use dialog to show all tours, instead of bs modal
- Fixed in Code Base
- 12 Sep 2023
- Medium
- Build: 5.0-dev
- # 41442
- Diff
- Fedik:popup-guidedtour-viewall
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Use Dialog to show "all guidedtours", instead of hardcoded BS modal.
BTW. It also can be changed to use AJAX for loading all tours, in future.
Testing Instructions
Apply patch.
Click "Show all tours"
Actual result BEFORE applying this Pull Request
You get a popup with all tours
Expected result AFTER applying this Pull Request
You get a popup with all tours, but better coded :)
Link to documentations
Please select:
- Documentation link for docs.joomla.org:
- No documentation changes for docs.joomla.org needed
- Pull Request link for manual.joomla.org:
- No documentation changes for manual.joomla.org needed
Reference:
Votes
joomla-cms-bot
- | Category | ⇒ | Modules Administration |
| Status | New | ⇒ | Pending |
I have tested this item ✅ successfully on 11d3a63
Tested succesfully
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41442.
| Labels |
Added:
Feature
PBF
PR-5.0-dev
?
|
||
I have tested this item ✅ successfully on b02b0df
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41442.
@rachelwalraven can you please re-test cause meanwhile a commit has been done
thanks in advance
I have not tested this item.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41442.
I have tested this item ✅ successfully on b02b0df
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41442.
sorry, marked "not tested" done by error.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41442.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41442.
I have tested this item ✅ successfully
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41442.
| Labels |
Added:
?
|
||
My list of guided tours, and the dialog box, are showing string keys rather than values. This both with and without the patch applied. And all of the key="string" titles and descriptions are in separate files. How come?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41442.
I think it is something broken in general, The translations is missing.
Seems one of recent changes broke it.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-09-12 18:10:45 |
| Closed_By | ⇒ | HLeithner |
thx
I have tested this item ✅ successfully on 11d3a63
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41442.
Joomla 5.0.0-beta1-dev