[#41443] - [5.0] Use own icon for dashboard due to fontawesome changes
- Fixed in Code Base
- 12 Sep 2023
- Medium
- Build: 5.0-dev
- # 41443
- Diff
- chmst:atum-icon-dashboard
User tests: Successful: Unsuccessful:
Pull Request for Issue #40748 .
Summary of Changes
An own dashboard icon was made by @angieradtke. Thank you!
I added a new folder into the atum image folder and changed the rendering for the atum submenu
Testing Instructions
Attention: needs npm or the package for test.
Actual result BEFORE applying this Pull Request
see #40748
Expected result AFTER applying this Pull Request
The dashboard looks as before in J4.x
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Modules Administration Repository NPM Change |
| Status | New | ⇒ | Pending |
| Title |
|
||||||
| Labels |
Added:
NPM Resource Changed
PR-5.0-dev
|
||
| Labels |
Added:
Backend Template
|
||
I have tested this item ✅ successfully on 3f7276a
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41443.
This feels not right to do it for just one icon. I understand it affects documentation, however, I am ok with the new icon as it is not completely different from the old one.
@angieradtke is the icon created by you? it looks extremely similar to the fontawesome 5 icon which could lead us into copyright troubles but I'm not lawyer so I have to ask...
@HLeithner I painted this icon with illustrator and then edited the source code in php storm. This is an icon with 4 squares that have a border radius. I can't judge how big the intellectual property of these four squares is, especially since font-awesome has modified this icon and uses the customized icon to display a grid. As far as I know font awesome is Open Font under SIL
@HLeithner I painted this icon with illustrator and then edited the source code in php storm. This is an icon with 4 squares that have a border radius. I can't judge how big the intellectual property of these four squares is, especially since font-awesome has modified this icon and uses the customized icon to display a grid. As far as I know font awesome is Open Font under SIL
perfect thanks then I can merge this.
I have tested this item ✅ successfully on f271ec1
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41443.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-09-12 13:39:03 |
| Closed_By | ⇒ | HLeithner |
I have tested this item ✅ successfully on a56ad7c
does what it says - no idea if this is the best way
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41443.