a11y Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
25 Aug 2023

Pull Request for Issue #41229 .

Summary of Changes

Standardises the strings so that they are in the same structure
Reworded the strings so that the links are unique and correctly describe where they are going
Adds and displays a missing string for recipes

Web links that are accessible and do not break WCAG standards

  • use clear and concise link text that describe the destination
  • make sure links take you to where you’d expect
  • Do not: have links that are not clear on destination such as ‘click here’ or ‘read more’

Testing Instructions

setup and configure the new schemaorg plugins. Open an article for editing and check the info box for any of the schema

Actual result BEFORE applying this Pull Request

image

image

Expected result AFTER applying this Pull Request

image

image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 25 Aug 2023
Category Administration Language & Strings Front End Plugins
avatar brianteeman brianteeman - open - 25 Aug 2023
avatar brianteeman brianteeman - change - 25 Aug 2023
Status New Pending
avatar HLeithner
HLeithner - comment - 25 Aug 2023

Is the "https://" schema necessary in the link text? It looks not really useful and ugly but it's your decision.

avatar brianteeman
brianteeman - comment - 25 Aug 2023

necessary - no

just something I always do when displaying a link. only a few existing instances in core and we do it both ways

avatar HLeithner
HLeithner - comment - 25 Aug 2023

Isn't it annoying for screenreaders? or do they ignore it / take a shortcut? Should we make it consistent?

If you want to keep it as it is I will merge it as it is.

avatar brianteeman
brianteeman - comment - 25 Aug 2023

Isn't it annoying for screenreaders? or do they ignore it / take a shortcut? Should we make it consistent?

If you want to keep it as it is I will merge it as it is.

i would prefer to keep it as it is

avatar HLeithner HLeithner - change - 25 Aug 2023
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-08-25 10:05:55
Closed_By HLeithner
Labels Added: a11y
avatar HLeithner HLeithner - close - 25 Aug 2023
avatar HLeithner HLeithner - merge - 25 Aug 2023
avatar HLeithner
HLeithner - comment - 25 Aug 2023

thx

Add a Comment

Login with GitHub to post a comment