[#41434] - [5.0] Use Joomla dialog for confirmation dialog, instead of old school confirm()
- Fixed in Code Base
- 4 Sep 2023
- Medium
- Build: 5.0-dev
- # 41434
- Diff
- Fedik:toolbar-confirm-dialog
User tests: Successful: Unsuccessful:
Summary of Changes
Use Joomla dialog for confirmation dialog, instead of old school confirm()
Also an example how it could be used in other places.
Testing Instructions
Apply patch, run npm install.
Trash some Article, and then try empty the trash.
Actual result BEFORE applying this Pull Request
You get old school confirm() dialog
Expected result AFTER applying this Pull Request
You get Joomla dialog
Link to documentations
Please select:
- Documentation link for docs.joomla.org:
- No documentation changes for docs.joomla.org needed
- Pull Request link for manual.joomla.org:
- No documentation changes for manual.joomla.org needed
Reference:
joomla-cms-bot
- | Category | ⇒ | Repository NPM Change JavaScript |
| Status | New | ⇒ | Pending |
I have tested this item ✅ successfully on ee1e199
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41434.
I have tested this item ? unsuccessfully on ee1e199
Translation (JYES, JNO) not loaded for footer buttons
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41434.
system tests are failing
system tests are failing
Yeap, I did not checked, but I think cypress expecting old confirm()
Need to debug
| Category | Repository NPM Change JavaScript | ⇒ | Repository NPM Change JavaScript Layout |
| Labels |
Added:
Feature
NPM Resource Changed
PR-5.0-dev
?
|
||
| Category | Repository NPM Change JavaScript Layout | ⇒ | Repository NPM Change JavaScript Layout Unit Tests |
| Labels |
Added:
?
|
||
| Category | Repository NPM Change JavaScript Layout Unit Tests | ⇒ | Administration Templates (admin) Repository NPM Change JavaScript Layout Unit Tests |
| Category | Repository NPM Change JavaScript Layout Unit Tests Administration Templates (admin) | ⇒ | Repository NPM Change JavaScript Layout Unit Tests |
Test can be fixed only after updating Firefox for Cypress
Test can be fixed only after updating Firefox for Cypress
Test running now with
- Cypress: 12.17.4
- Browser: Firefox 114 (headless)
- Node Version: v20.5.0
After removing failed tests it is working now.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-09-04 09:13:50 |
| Closed_By | ⇒ | HLeithner |
thanks
I think we need a migration documentation?
I think we need a migration documentation?
yes please as there are other places we can use this