Language Change bug PR-4.4-dev Pending

User tests: Successful: Unsuccessful:

avatar joomleb
joomleb
23 Aug 2023

Hi guys,
the language string
COM_USERS_PROFILE_VALUE_NOT_FOU=”Website default”

It is used in User Profile fields page when the user still has not choose any value (left it empty).

It would be really better as: ”Not configured" or something similar,

Do you agree ?

Pull Request for Issue # .

Summary of Changes

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 23 Aug 2023
Category Language & Strings
avatar joomleb joomleb - open - 23 Aug 2023
avatar joomleb joomleb - change - 23 Aug 2023
Status New Pending
avatar Kostelano
Kostelano - comment - 23 Aug 2023

In fact, everything is "Configured", i.e. leave the language the same as on the site.

avatar brianteeman
brianteeman - comment - 23 Aug 2023

I dont see why you would want to change it. This pattern is used throughout joomla.

avatar joomleb
joomleb - comment - 24 Aug 2023

Hi guys,
"Website default" it is a good choice for most of the Joomla "Frontend User Parameters", but, as far as I know it is the standard language string that have to be used by all the 3rd party User Profile plugins, Am I right ?

Often, are fields that have no a "default" setting, just the user still has not input any value (he left it empty a no mandatory field). Like for example "Birthday", "Address" etc. In this cases "Website default" sounds inappropriate.

While "Not configured" (or similar) could cover both cases. This is why...

avatar brianteeman
brianteeman - comment - 24 Aug 2023

"Website default" it is a good choice for most of the Joomla "Frontend User Parameters", but, as far as I know it is the standard language string that have to be used by all the 3rd party User Profile plugins, Am I right ?

Please give an example of such a plugin. I dont see why they cannot use their own language strings.

Often, are fields that have no a "default" setting, just the user still has not input any value (he left it empty a no mandatory field). Like for example "Birthday", "Address" etc. In this cases "Website default" sounds inappropriate.

It is inappropriate but I dont see why it i using that string

avatar joomleb
joomleb - comment - 28 Aug 2023

Hi @brianteeman
sure, you can see it in action going here
Login with emlnbrtl@gmail.com / emlnbrtl@gmail.com
and then surf to the Profile page

Anyway,

"...I don't see why they cannot use their own language strings..." = In my opinion it is a good thing to have a standard language string for 3rd party Extensions to be used for empty fields. Like: "Not configured".

While for all the fields that when not yet setted they redirect to a "site default value" would be really better, as a Joomla rule, just to show the default value and not the written "site default".
A developer and a Joomla backend Administrar they sure know what is the "default" value, but a "normal" User that is Registering / Editing his Profile in a Joomla Frontend site does not know what is the "default value" and then know and decide whether to change it.

So, for example:

  • Time Zone: Website default
  • Frontend Language: Website default

Would be shown directly as:

  • Time Zone: UTC-5
  • Frontend Language: Spanish

Where "UTC-5" and "Spanish" are the default values

avatar brianteeman
brianteeman - comment - 28 Aug 2023

"...I don't see why they cannot use their own language strings..." = In my opinion it is a good thing to have a standard language string for 3rd party Extensions to be used for empty fields. Like: "Not configured".

Not configured but using a default value and not configured so no value is used are not the same thing.

The string in this PR is always used to indicate that a default value is being used.

If an extension is using it for another purpose (in error) then you should take that up with them.

While for all the fields that when not yet settled they redirect to a "site default value" would be really better, as a Joomla rule, just to show the default value and not the written "site default".

agree 100% but thats off topic for this PR

avatar joomleb
joomleb - comment - 28 Aug 2023

Hi @brianteeman
"...The string in this PR is always used to indicate that a default value is being used..." = Please, Am I missing a specific language string yet existing for the "not configured so no value is used are not the same thing" ?
Because I looked for it without success before to open this PR and being that the Language String name is COM_USERS_PROFILE_VALUE_NOT_FOU=, "not found", I thought it doesn't exist.

"...agree 100% but thats off topic for this PR..." = Please, Will you escalate this one and/or Do I have to open a Discussion/PR ?

avatar brianteeman
brianteeman - comment - 28 Aug 2023

SORRY!!!

I just checked the core user profile plugin.

I expected it to display like this

image

But it actually displayed as
image

So you are 100% correct and there is a problem. I just think your solution may not be the best. I will take a look at it now.

avatar brianteeman
brianteeman - comment - 28 Aug 2023

... and full disclosure it was ME that broke this behaviour #25699

As you can see from that PR the string was changed for a good reason but it had unexpected consequences which you have found (suprised no one else spotted it before).

In summary its a valid issue but needs something more than a language string change to fix it

avatar joomleb
joomleb - comment - 28 Aug 2023

Well, about the "good reason", the "...Far better to say "Website default" as at least that way there is no confusion to the user. In the form they "selected" the -use default - option so to their understanding they have made a selection..." = For these fields there is no the option to do not select nothing, to leave them empties, so from a Normal User point of view, it does not matter if I selected / input it or not, what is important is to know what it is, the value that is running. Don't forget that these fields could be not only private fields, but also public fields that all other users can view.

My personal point of view is "less words as possible", so it is yet multilanguage and mobile ready (saving layout space). For that reason I would apply the rules:

  • For all the fields that when not yet setted they redirect to a "site default value" = just to show the default value and not the written "site default".
  • For all fields that can be left empty = just to don't show nothing, any value, left it empty.

simple, painless, efficient.

About the "SORRY!!!" and the "surprised no one else spotted it before" (me too) - There is no any problem. I perfectly understand you. I'm not a real developer, but I'm here from the first day, August 2005, living the Mambo splitting. It can happen. Often because you are focused on hard core development, while I'm focused on my "normal" Users Experience.
Many times details that for you are "nothing", for my Users are "panic".
Our marketing experiences statistics says that the most difficult pass for our success sites is to convince the User to a "Free Register now", so on last month's I just focused on it and in fact I opened a lot of issues/suggestions tickets here with the goal of a smoother secure Registration, Login/Logout user experience...

avatar brianteeman
brianteeman - comment - 29 Aug 2023

Please take a look at #41513

avatar joomleb
joomleb - comment - 29 Aug 2023

@brianteeman
Thank you, so:

The #41513 solve the

For all fields that can be left empty = just to don't show nothing, any value, left it empty.

What about the ...?

For all the fields that when not yet setted they redirect to a "site default value" = just to show the default value and not the written "site default".

I still think that from a Normal User point of view,, frontend, it does not matter if I selected / input it or not, what is important is to know what it is, the value that is running. Don't forget that these fields could be not only private fields, but also public fields that all other users can view.

Maybe, from an Administrator point of view, backend, could be useful to know if the User made a selection or not.
So, my proposal for all the fields that when not yet setted they redirect to a "site default value":

  • On all Frontend layouts, just to show directly the relative default value and not the written "site default".

  • On all Backend layouts, as it is now, to show the written "site default".

avatar brianteeman
brianteeman - comment - 29 Aug 2023

Please test the pull request I created. I believe it solves all your issues.

avatar joomleb
joomleb - comment - 29 Aug 2023

@brianteeman
as Documented here
I'm not able to find the Prebuild Package here
Please, What am I missing ?

avatar brianteeman
brianteeman - comment - 29 Aug 2023

You're not missing anything - something went wrong building the packages. I have retriggered the process

avatar brianteeman
brianteeman - comment - 29 Aug 2023
avatar joomleb
joomleb - comment - 30 Aug 2023

@brianteeman
I updated the Test site

Frontend

For all fields that can be left empty = just to don't show nothing, any value, left it empty.

Are you sure the rule is applying by default also on the Users Joomla Custom Fields ?
I created a Calendar (Birthday) Joomla Custom Field and "Website Default"is still shown.

For all the fields that when not yet setted they redirect to a "site default value" like the "Basic Settings" fields (Time Zone, Frontend Language,...) = just to show the default value and not the written "site default".

Right now also here it is showing nothing as above, instead to show the value

avatar brianteeman
brianteeman - comment - 30 Aug 2023

I created a Calendar (Birthday) Joomla Custom Field and "Website Default"is still shown.

I can not replicate that with the pull request applied

image

avatar joomleb
joomleb - comment - 30 Aug 2023

@brianteeman
I thought to reinstall the Package Update, but again I cannot redownload the Prebuilt Package (File not found).

Anyway I re tested creating a new Calendar Custom Field and a Text Custom Field.
For all Custom Fields the "Website Default" is still shown. You can see them on the Test site.

Please, is there a way to privately send you the Super Admin credentials?

avatar joomleb
joomleb - comment - 4 Sep 2023

@brianteeman I remain available...

avatar HLeithner
HLeithner - comment - 30 Sep 2023

This pull request has been automatically rebased to 4.4-dev.

avatar joomleb joomleb - change - 10 Nov 2023
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2023-11-10 14:12:14
Closed_By joomleb
Labels Added: Language Change bug PR-4.4-dev
avatar joomleb joomleb - close - 10 Nov 2023

Add a Comment

Login with GitHub to post a comment