Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#41361] - [4.3] uppercase image file in preview

? NPM Resource Changed PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
13 Aug 2023

Pull Request for Issue #41343 . Alternative to #41356

Summary of Changes

Allow UPPERCASE, and MiXeD case extensions for all the media files

Testing Instructions

Rename the file images/joomla_black.png to images/joomla_black.PNG and then select it as the intro image in an article

Actual result BEFORE applying this Pull Request

Preview broken

Expected result AFTER applying this Pull Request

Preview works

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 13 Aug 2023
Category ⇒ JavaScript Repository NPM Change
avatar dgrammatiko dgrammatiko - open - 13 Aug 2023
avatar dgrammatiko dgrammatiko - change - 13 Aug 2023
Status New ⇒ Pending
avatar dgrammatiko dgrammatiko - change - 13 Aug 2023
The description was changed
avatar dgrammatiko dgrammatiko - edited - 13 Aug 2023
avatar Quy Quy - test_item - 13 Aug 2023 - Tested successfully
avatar Quy
Quy - comment - 13 Aug 2023

I have tested this item ✅ successfully on 78b848d

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41361.

avatar viocassel viocassel - test_item - 13 Aug 2023 - Tested successfully
avatar viocassel
viocassel - comment - 13 Aug 2023

I have tested this item ✅ successfully on 78b848d

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41361.

avatar Quy Quy - change - 13 Aug 2023
Status Pending ⇒ Ready to Commit
Labels Added: PR-4.3-dev
avatar Quy
Quy - comment - 13 Aug 2023

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41361.

avatar dgrammatiko
dgrammatiko - comment - 14 Aug 2023

Just a note here:
Allow UPPERCASE, and MiXeD case extensions for all the media files refers ONLY to the preview part of the media field. There is absolutely NO change to the upload functionality (no security concerns).
Also the local storage adapter is ALWAYS saving the extensions as lowercase:

joomla-cms/plugins/filesystem/local/src/Adapter/LocalAdapter.php

Lines 796 to 798 in 642de29

// Normalise extension, always lower case
if ($extension) {
$extension = '.' . strtolower($extension);

avatar Quy Quy - change - 28 Aug 2023
Labels Added: ?
avatar obuisard obuisard - change - 28 Aug 2023
Labels Added: NPM Resource Changed
avatar obuisard obuisard - close - 28 Aug 2023
avatar obuisard obuisard - merge - 28 Aug 2023
avatar obuisard obuisard - change - 28 Aug 2023
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2023-08-28 17:16:34
Closed_By ⇒ obuisard
avatar obuisard
obuisard - comment - 28 Aug 2023

Thanks Dimitris @dgrammatiko for the PR!

Add a Comment

Login with GitHub to post a comment