? PR-4.4-dev Pending

User tests: Successful: Unsuccessful:

avatar obuisard
obuisard
13 Aug 2023

Pull Request for Issue #41291. Rewrite of PR #41307 wrongly merged in 4.3.

System test needed. Please see #41307 (comment)

avatar joomla-cms-bot joomla-cms-bot - change - 13 Aug 2023
Category Administration com_categories
avatar obuisard obuisard - open - 13 Aug 2023
avatar obuisard obuisard - change - 13 Aug 2023
Status New Pending
avatar alikon alikon - test_item - 14 Aug 2023 - Tested successfully
avatar alikon
alikon - comment - 14 Aug 2023

I have tested this item successfully on fc49dc2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41362.

avatar laoneo
laoneo - comment - 14 Aug 2023

Thank you very much, can you extend the system test here https://github.com/joomla/joomla-cms/blob/4.4-dev/tests/System/integration/api/com_content/Categories.cy.js#L4-L17 so the description field is tested as well. I know we do not test the other fields yet, but I would like to enhance the system tests when we do such small pr's.

avatar obuisard
obuisard - comment - 23 Aug 2023

Nicola @alikon, would you mind looking into the system tests that are required? Thank you!

avatar alikon
alikon - comment - 23 Aug 2023

@obuisard i would like to do it, but still fighting with an issue already reported upstream cypress-io/cypress#25357

avatar alikon
alikon - comment - 25 Aug 2023

@obuisard i've made a pr obuisard#8 for the system test

avatar obuisard
obuisard - comment - 25 Aug 2023

@obuisard i've made a pr obuisard#8 for the system test

Thank you so much Nicola @alikon!

avatar laoneo
laoneo - comment - 26 Aug 2023

@obuisard can you merge the pr from @alikon?

avatar obuisard obuisard - change - 26 Aug 2023
Labels Added: ? PR-4.4-dev
avatar obuisard obuisard - change - 26 Aug 2023
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-08-26 19:10:20
Closed_By obuisard
avatar obuisard obuisard - close - 26 Aug 2023
avatar obuisard obuisard - merge - 26 Aug 2023
avatar obuisard
obuisard - comment - 26 Aug 2023

OMG I mis-understood what was asked of me Allon @laoneo, my fault from looking at the issue from a phone in the heat of PBF where my brain was all over... I rectified by creating a new PR with the tests only.
My apologies for the mess up, on a PR I should never have merged in the first place...

If you decide to revert this PR, no problem, I will recreate it as part of #41479.

Add a Comment

Login with GitHub to post a comment